Opened 7 years ago

Closed 7 years ago

#20011 closed enhancement (fixed)

Deprecate rings/commutative_ring.py and friends

Reported by: Jeroen Demeyer Owned by:
Priority: major Milestone: sage-7.1
Component: misc Keywords:
Cc: Merged in:
Authors: Jeroen Demeyer Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: d200bac (Commits, GitHub, GitLab) Commit: d200bac36dc02ba48a6bd1457653081486d80024
Dependencies: Stopgaps:

Status badges

Description (last modified by Jeroen Demeyer)

The following modules contain only is_... functions and should be removed:

sage/rings/commutative_ring.py
sage/rings/dedekind_domain.py
sage/rings/euclidean_domain.py
sage/rings/integral_domain.py
sage/rings/principal_ideal_domain.py

Change History (5)

comment:1 Changed 7 years ago by Jeroen Demeyer

Description: modified (diff)

comment:2 Changed 7 years ago by Jeroen Demeyer

Branch: u/jdemeyer/deprecate_rings_commutative_ring_py_and_friends

comment:3 Changed 7 years ago by Jeroen Demeyer

Commit: d200bac36dc02ba48a6bd1457653081486d80024
Status: newneeds_review

New commits:

d200bacDeprecate rings/commutative_ring.py and friends

comment:4 Changed 7 years ago by Travis Scrimshaw

Reviewers: Travis Scrimshaw
Status: needs_reviewpositive_review

LGTM.

comment:5 Changed 7 years ago by Volker Braun

Branch: u/jdemeyer/deprecate_rings_commutative_ring_py_and_friendsd200bac36dc02ba48a6bd1457653081486d80024
Resolution: fixed
Status: positive_reviewclosed
Note: See TracTickets for help on using tickets.