Opened 3 years ago

Closed 3 years ago

#20011 closed enhancement (fixed)

Deprecate rings/commutative_ring.py and friends

Reported by: jdemeyer Owned by:
Priority: major Milestone: sage-7.1
Component: misc Keywords:
Cc: Merged in:
Authors: Jeroen Demeyer Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: d200bac (Commits) Commit: d200bac36dc02ba48a6bd1457653081486d80024
Dependencies: Stopgaps:

Description (last modified by jdemeyer)

The following modules contain only is_... functions and should be removed:

sage/rings/commutative_ring.py
sage/rings/dedekind_domain.py
sage/rings/euclidean_domain.py
sage/rings/integral_domain.py
sage/rings/principal_ideal_domain.py

Change History (5)

comment:1 Changed 3 years ago by jdemeyer

  • Description modified (diff)

comment:2 Changed 3 years ago by jdemeyer

  • Branch set to u/jdemeyer/deprecate_rings_commutative_ring_py_and_friends

comment:3 Changed 3 years ago by jdemeyer

  • Commit set to d200bac36dc02ba48a6bd1457653081486d80024
  • Status changed from new to needs_review

New commits:

d200bacDeprecate rings/commutative_ring.py and friends

comment:4 Changed 3 years ago by tscrim

  • Reviewers set to Travis Scrimshaw
  • Status changed from needs_review to positive_review

LGTM.

comment:5 Changed 3 years ago by vbraun

  • Branch changed from u/jdemeyer/deprecate_rings_commutative_ring_py_and_friends to d200bac36dc02ba48a6bd1457653081486d80024
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.