Opened 7 years ago

Closed 6 years ago

#20001 closed enhancement (fixed)

Decoders and types for linear codes

Reported by: David Lucas Owned by:
Priority: major Milestone: sage-7.2
Component: coding theory Keywords: rd3
Cc: David Lucas, Clément Pernet, Julien Lavauzelle, Daniel Augot Merged in:
Authors: David Lucas, Johan Rosenkilde Reviewers: Johan Rosenkilde
Report Upstream: N/A Work issues:
Branch: 6e9c1dc (Commits, GitHub, GitLab) Commit: 6e9c1dc2916bd817877da303b4a2719e322f3d9a
Dependencies: Stopgaps:

Status badges

Description

Decoders objects in coding theory are associated with a list of types, which are a list of keywords describing to the user the specificites of the underlying decoding algorithm.

For now, the types are not listed nor defined anywhere.

This ticket proposes to create a proper list of types and their definitions.

Change History (12)

comment:1 Changed 7 years ago by Karan Desai

Could you please mention the files you intend to point out in the sage directory tree ?

comment:2 Changed 7 years ago by David Lucas

Hello,

I intend to create a list of types and their definitions in decoder.py (sage.coding.decoder), under the generic method decoder_type.

Actually, I originally did that in #19897, but after a discussion in #19623, we found that defining precisely types for decoders wasn't such an easy thing, hence this ticket.

David

comment:3 Changed 7 years ago by David Lucas

Cc: David Lucas Clément Pernet Julien Lavauzelle Daniel Augot added
Milestone: sage-7.1sage-7.2

comment:4 Changed 6 years ago by Daniel Augot

Hi,

I do not clearly understand what is asked for.

Do you want a codes.decoders.decoder_types() call, which lists all decoder "types" (I would rather call that properties), with a extremely clean docstring for codes.decoders.decoder_types ?

Daniel

Version 1, edited 6 years ago by Daniel Augot (previous) (next) (diff)

comment:5 Changed 6 years ago by Ricardo Alfaro

I put my comments in the Issue #151 that Johan pointed out to me. It gives a suggestion on redefining the decoder types.

comment:6 Changed 6 years ago by David Lucas

Branch: u/dlucas/decoder_types

comment:7 Changed 6 years ago by David Lucas

Authors: David Lucas
Commit: 37e738f37217f2458e57d04e0870a4e0a067e20c
Keywords: rd3 added
Status: newneeds_review

I pushed a table which contains a list of decoder types and their definitions. Open for review.


New commits:

37e738fTable for decoder types

comment:8 Changed 6 years ago by Johan Rosenkilde

Branch: u/dlucas/decoder_typesu/jsrn/decoder_types

comment:9 Changed 6 years ago by Johan Rosenkilde

Commit: 37e738f37217f2458e57d04e0870a4e0a067e20c6e9c1dc2916bd817877da303b4a2719e322f3d9a

I made some improvements:

  • Some reformulations.
  • Used simpler table format for future modifications.
  • The doc was not present on Decoder instances (which is where most users will see them). I wrote introspection code which propagates the doc of decoder_type to _instance_decoder_type to fix this.

If you're OK, let's get this thing in the air!


New commits:

70e6052Reformulated some elements. Simpler table format
6e9c1dcDon't duplicate doc-string in decoder_type and _instance_decoder_type

comment:10 Changed 6 years ago by Johan Rosenkilde

Authors: David LucasDavid Lucas, Johan Rosenkilde
Reviewers: Johan Rosenkilde

comment:11 Changed 6 years ago by David Lucas

Status: needs_reviewpositive_review

I'm OK, setting to positive review.

David

comment:12 Changed 6 years ago by Volker Braun

Branch: u/jsrn/decoder_types6e9c1dc2916bd817877da303b4a2719e322f3d9a
Resolution: fixed
Status: positive_reviewclosed
Note: See TracTickets for help on using tickets.