Opened 4 years ago

Closed 4 years ago

#19976 closed enhancement (duplicate)

Optimize Cython dependency checking

Reported by: jdemeyer Owned by:
Priority: major Milestone: sage-duplicate/invalid/wontfix
Component: packages: standard Keywords:
Cc: robertwb Merged in:
Authors: Reviewers: Jeroen Demeyer
Report Upstream: Fixed upstream, in a later stable release. Work issues:
Branch: u/jdemeyer/optimize_cython_dependency_checking (Commits) Commit: f82bc310bf2c14801d1b9a2d8af28d926dfe2c87
Dependencies: Stopgaps:

Description (last modified by jdemeyer)

Upgrade to Cython 0.23.4 and add the following patch: https://github.com/cython/cython/pull/461

This improves the dependency checking in Cython. One consequence is that the following is completely gone when doing ./sage -b:

copying /usr/local/src/sage-git/src/build/cythonized/sage/matroids/minorfix.h -> /usr/local/src/sage-git/local/lib/python2.7/site-packages/sage/matroids
copying /usr/local/src/sage-git/src/build/cythonized/sage/stats/distributions/dgs_misc.h -> /usr/local/src/sage-git/local/lib/python2.7/site-packages/sage/stats/distributions
...
copying /usr/local/src/sage-git/src/build/cythonized/sage/symbolic/pynac_cc.h -> /usr/local/src/sage-git/local/lib/python2.7/site-packages/sage/symbolic
copying /usr/local/src/sage-git/src/build/cythonized/sage/symbolic/ginac_wrap.h -> /usr/local/src/sage-git/local/lib/python2.7/site-packages/sage/symbolic

Tarball: http://cython.org/release/Cython-0.23.4.tar.gz


Timings for ./sage -b when no changes need to be made (best out of 6):

Before:

real    0m4.402s
user    0m3.502s
sys     0m0.523s

After:

real    0m3.478s
user    0m3.061s
sys     0m0.320s

The difference for the Cythonization part of ./sage -b (best out of 6):

Before:

Finished Cythonizing, time: 3.63 seconds.

After:

Finished Cythonizing, time: 2.71 seconds.

Change History (7)

comment:1 Changed 4 years ago by jdemeyer

  • Description modified (diff)

comment:2 Changed 4 years ago by jdemeyer

  • Description modified (diff)

comment:3 Changed 4 years ago by jdemeyer

  • Description modified (diff)

comment:4 Changed 4 years ago by jdemeyer

  • Branch set to u/jdemeyer/optimize_cython_dependency_checking

comment:5 Changed 4 years ago by jdemeyer

  • Cc robertwb added
  • Commit set to f82bc310bf2c14801d1b9a2d8af28d926dfe2c87
  • Description modified (diff)
  • Status changed from new to needs_review

New commits:

f82bc31Optimize Cython dependency checking

comment:6 Changed 4 years ago by jdemeyer

  • Authors Jeroen Demeyer deleted
  • Milestone changed from sage-7.1 to sage-duplicate/invalid/wontfix
  • Report Upstream changed from Reported upstream. No feedback yet. to Fixed upstream, in a later stable release.
  • Reviewers set to Jeroen Demeyer
  • Status changed from needs_review to positive_review

Obsoleted by #20192.

comment:7 Changed 4 years ago by vbraun

  • Resolution set to duplicate
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.