Changes between Initial Version and Version 1 of Ticket #19963, comment 12


Ignore:
Timestamp:
02/08/16 08:42:33 (5 years ago)
Author:
fbissey
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #19963, comment 12

    initial v1  
    1 I am unfortunately taking this train after it left the station. I guess the code re-organisation had to happen in #19127 and all. But what a choice of variable names. Seriously `SAGE_DOC_OUTPUT`? Yes I can see how where it came from. But seriously I expect my doc to be found under `SAGE_DOC` not `SAGE_DOC_OUTPUT`, that's the natural name to use. The other one could have been `SAGE_DOC_SRC`, and if it isn't used after install I am not sure I would bother putting it in `env.py`.
     1I am unfortunately taking this train after it left the station. I guess the code re-organisation had to happen in #19127 and all. But what a choice of variable names. Seriously `SAGE_DOC_OUTPUT`? Yes I can see where it came from. But seriously I expect my doc to be found under `SAGE_DOC` not `SAGE_DOC_OUTPUT`, that's the natural name to use. The other one could have been `SAGE_DOC_SRC`, and if it isn't used after install I am not sure I would bother putting it in `env.py`.