Opened 6 years ago

Closed 6 years ago

#19948 closed enhancement (fixed)

Upgrade to pynac-0.6.1

Reported by: rws Owned by:
Priority: major Milestone: sage-7.1
Component: packages: standard Keywords:
Cc: behackl Merged in:
Authors: Ralf Stephan Reviewers: Benjamin Hackl
Report Upstream: N/A Work issues:
Branch: 8a9b6ac (Commits, GitHub, GitLab) Commit: 8a9b6ac2388fe965fd7139f3d86dc76064231d17
Dependencies: Stopgaps:

Status badges

Description (last modified by jdemeyer)

Brand new pynac has:

  • Stieltjes constant function (#19834)
  • zeta expansion at 1 using stieltjes() (#19836, thanks Benjamin Hackl)
  • fix hashing of infinities (#19928)
  • fix exp and atan of oo (#19918)
  • fix pseries print order
  • speedups and fixes from GiNaC


Change History (12)

comment:1 Changed 6 years ago by jdemeyer

  • Description modified (diff)

comment:2 Changed 6 years ago by rws

  • Branch set to u/rws/upgrade_to_pynac_0_6_1

comment:3 Changed 6 years ago by rws

  • Authors set to Ralf Stephan
  • Cc behackl added
  • Commit set to b76a8adf9cea5807b3883969682940a04556cedc
  • Status changed from new to needs_review

New commits:

5c8814119448: update Pynac pkg data
b76a8ad19948: add stieltjes() interface; fix doctest

comment:4 Changed 6 years ago by behackl

Interface and doctest changes LGTM; currently running ptestlong.

comment:5 Changed 6 years ago by jdemeyer

  • Status changed from needs_review to needs_work

Should this be ValueError?

raise AttributeError("Stieltjes constant of negative index")

comment:6 Changed 6 years ago by git

  • Commit changed from b76a8adf9cea5807b3883969682940a04556cedc to 4857402486ec65ba6cd0fdbcfe60411109e0ce05

Branch pushed to git repo; I updated commit sha1. New commits:

485740219949: fix type of error raised by stieltjes()

comment:7 Changed 6 years ago by rws

  • Status changed from needs_work to needs_review

You're right.

comment:8 Changed 6 years ago by behackl

Sorry, missed the error type. In any case:

ptestlong passes on two separate machines. Would be positive_review from my side.

comment:9 Changed 6 years ago by jdemeyer

  • Reviewers set to Benjamin Hackl
  • Status changed from needs_review to positive_review

comment:10 Changed 6 years ago by jdemeyer

  • Branch changed from u/rws/upgrade_to_pynac_0_6_1 to u/jdemeyer/upgrade_to_pynac_0_6_1

comment:11 Changed 6 years ago by jdemeyer

  • Commit changed from 4857402486ec65ba6cd0fdbcfe60411109e0ce05 to 8a9b6ac2388fe965fd7139f3d86dc76064231d17

The ticket number in 2 of the 3 commit messages was wrong. I squashed the commits and fixed the commit message.

New commits:

8a9b6acTrac #19948: Upgrade to pynac-0.6.1

comment:12 Changed 6 years ago by vbraun

  • Branch changed from u/jdemeyer/upgrade_to_pynac_0_6_1 to 8a9b6ac2388fe965fd7139f3d86dc76064231d17
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.