Opened 5 years ago

Closed 5 years ago

#19940 closed enhancement (fixed)

Remove unused _set_parent_c and _make_new_with_parent_c

Reported by: jdemeyer Owned by:
Priority: major Milestone: sage-7.1
Component: misc Keywords:
Cc: tscrim Merged in:
Authors: Jeroen Demeyer Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: 453b400 (Commits) Commit: 453b400fd28a79e2279e26e5f495edade0e83469
Dependencies: #19934 Stopgaps:

Description


Change History (5)

comment:1 Changed 5 years ago by jdemeyer

  • Branch set to u/jdemeyer/remove_unused__set_parent_c

comment:2 Changed 5 years ago by jdemeyer

  • Commit set to 453b400fd28a79e2279e26e5f495edade0e83469
  • Status changed from new to needs_review
  • Summary changed from Remove unused _set_parent_c to Remove unused _set_parent_c and _make_new_with_parent_c

New commits:

​8a69e19Remove redundant uses of ParentWithBase and ParentWithGens
​453b400Remove unused _set_parent_c and _make_new_with_parent_c

comment:3 Changed 5 years ago by jdemeyer

  • Cc tscrim added
  • Dependencies set to #19934

comment:4 Changed 5 years ago by tscrim

  • Reviewers set to Travis Scrimshaw
  • Status changed from needs_review to positive_review

LGTM.

comment:5 Changed 5 years ago by vbraun

  • Branch changed from u/jdemeyer/remove_unused__set_parent_c to 453b400fd28a79e2279e26e5f495edade0e83469
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.