Opened 6 years ago
Closed 6 years ago
#19934 closed enhancement (fixed)
Remove redundant imports of ParentWithGens/ParentWithBase
Reported by: | jdemeyer | Owned by: | |
---|---|---|---|
Priority: | major | Milestone: | sage-7.1 |
Component: | misc | Keywords: | |
Cc: | Merged in: | ||
Authors: | Jeroen Demeyer | Reviewers: | Travis Scrimshaw |
Report Upstream: | N/A | Work issues: | |
Branch: | 8a69e19 (Commits, GitHub, GitLab) | Commit: | 8a69e19d2fa013c3db6887625c02eac4e4a98ba8 |
Dependencies: | Stopgaps: |
Description (last modified by )
While grepping the Sage source code to see where the old ParentWithGens
/ParentWithBase
is still used, I noticed various places where it's imported but unused or where its use can easily be replaced by Parent
.
Change History (6)
comment:1 Changed 6 years ago by
- Description modified (diff)
- Summary changed from Remove redundant imports of ParentWithGens to Remove redundant imports of ParentWithGens/ParentWithBase
comment:2 Changed 6 years ago by
- Description modified (diff)
comment:3 Changed 6 years ago by
- Branch set to u/jdemeyer/remove_redundant_imports_of_parentwithgens
comment:4 Changed 6 years ago by
- Commit set to 8a69e19d2fa013c3db6887625c02eac4e4a98ba8
- Status changed from new to needs_review
comment:5 Changed 6 years ago by
- Reviewers set to Travis Scrimshaw
- Status changed from needs_review to positive_review
LGTM.
comment:6 Changed 6 years ago by
- Branch changed from u/jdemeyer/remove_redundant_imports_of_parentwithgens to 8a69e19d2fa013c3db6887625c02eac4e4a98ba8
- Resolution set to fixed
- Status changed from positive_review to closed
Note: See
TracTickets for help on using
tickets.
New commits:
Remove redundant uses of ParentWithBase and ParentWithGens