Opened 6 years ago

Closed 6 years ago

#19933 closed defect (fixed)

MemoryInfo.rlimit_address_space() should return -1 for unlimited

Reported by: jdemeyer Owned by:
Priority: major Milestone: sage-7.1
Component: misc Keywords:
Cc: Merged in:
Authors: Jeroen Demeyer Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: 20d6d64 (Commits, GitHub, GitLab) Commit: 20d6d64a4b465225f8677ad3ecca453d544bdc64
Dependencies: Stopgaps:

Status badges

Description (last modified by jdemeyer)

The code in memory_info.py is written with the assumption that RLIM_INFINITY = -1. This is true on Linux, but not on OS X.

Change History (5)

comment:1 Changed 6 years ago by jdemeyer

  • Branch set to u/jdemeyer/memoryinfo_rlimit_address_space___should_return__1_for_unlimited

comment:2 Changed 6 years ago by jdemeyer

  • Commit set to 20d6d64a4b465225f8677ad3ecca453d544bdc64
  • Status changed from new to needs_review

New commits:

20d6d64Fix unlimited memory

comment:3 Changed 6 years ago by jdemeyer

  • Description modified (diff)

comment:4 Changed 6 years ago by tscrim

  • Reviewers set to Travis Scrimshaw
  • Status changed from needs_review to positive_review

LGTM.

comment:5 Changed 6 years ago by vbraun

  • Branch changed from u/jdemeyer/memoryinfo_rlimit_address_space___should_return__1_for_unlimited to 20d6d64a4b465225f8677ad3ecca453d544bdc64
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.