Opened 4 years ago

Closed 4 years ago

#19931 closed enhancement (fixed)

exact_part for asymptotic expansions

Reported by: behackl Owned by:
Priority: major Milestone: sage-7.1
Component: asymptotic expansions Keywords:
Cc: dkrenn, cheuberg Merged in:
Authors: Benjamin Hackl Reviewers: Clemens Heuberger
Report Upstream: N/A Work issues:
Branch: 7276172 (Commits) Commit: 72761726f089fbf1edc5797d8cd114a4da84815b
Dependencies: Stopgaps:

Description (last modified by behackl)

For various reasons, having a method expansion.exact_part that returns the asymptotic expansion that consists of all ExactTerm-summands would be very useful.

This ticket provides such a method.

Change History (6)

comment:1 Changed 4 years ago by behackl

  • Authors set to Benjamin Hackl
  • Branch set to u/behackl/asy/exact_part
  • Commit set to 8aa55e2fe0bd8c448658de35a4e384809fe00d42
  • Description modified (diff)
  • Status changed from new to needs_review

New commits:

8aa55e2implement exact_part

comment:2 follow-up: Changed 4 years ago by cheuberg

  • Status changed from needs_review to needs_work

I'd prefer to copy the expression and to delete all non-exact elements. In general, this should be more efficient than recreating a poset with almost all elements --- after all, in general, there will be more exact terms than error terms.

comment:3 Changed 4 years ago by git

  • Commit changed from 8aa55e2fe0bd8c448658de35a4e384809fe00d42 to 72761726f089fbf1edc5797d8cd114a4da84815b

Branch pushed to git repo; I updated commit sha1. New commits:

7276172delete terms from copy instead of building new poset

comment:4 in reply to: ↑ 2 Changed 4 years ago by behackl

  • Status changed from needs_work to needs_review

Replying to cheuberg:

I'd prefer to copy the expression and to delete all non-exact elements. In general, this should be more efficient than recreating a poset with almost all elements --- after all, in general, there will be more exact terms than error terms.

I agree, this strategy seems to be more efficient than building the entire expansion again. I've adapted the implementation.

comment:5 Changed 4 years ago by cheuberg

  • Reviewers set to Clemens Heuberger
  • Status changed from needs_review to positive_review

Doctests pass according to patchbot, documentation builds, code now fine.

comment:6 Changed 4 years ago by vbraun

  • Branch changed from u/behackl/asy/exact_part to 72761726f089fbf1edc5797d8cd114a4da84815b
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.