Opened 4 years ago

Closed 4 years ago

#19921 closed defect (fixed)

Handle zero coefficients when converting asymptotic rings

Reported by: cheuberg Owned by:
Priority: major Milestone: sage-7.1
Component: asymptotic expansions Keywords:
Cc: dkrenn, behackl Merged in:
Authors: Clemens Heuberger, Daniel Krenn Reviewers: Daniel Krenn, Clemens Heuberger
Report Upstream: N/A Work issues:
Branch: 3c109a2 (Commits) Commit: 3c109a2e942d023ae7dd9ed93665bdc0ac011d15
Dependencies: #19528 Stopgaps:

Description (last modified by cheuberg)

sage: CR.<Z> = QQ['Z']
sage: CR_mod = CR.quotient((Z^2 - 1)*CR)
sage: R.<x> = AsymptoticRing(growth_group='x^NN', coefficient_ring=CR)
sage: R_mod = R.change_parameter(coefficient_ring=CR_mod)
sage: e = 1 + x*(Z^2-1)
sage: R_mod(e)
Traceback (most recent call last):
...
ValueError: Cannot include Z^2 - 1*x with parent Exact Term Monoid
x^((Non negative integer semiring)) with coefficients in Univariate
Polynomial Ring in Z over Rational Field in Asymptotic Ring
<x^((Non negative integer semiring))> over Univariate Quotient Polynomial
Ring in Zbar over Rational Field with modulus Z^2 - 1
> *previous* ValueError: Zero coefficient 0 is not allowed in Exact
Term Monoid x^((Non negative integer semiring)) with coefficients
in Univariate Quotient Polynomial Ring in Zbar over Rational Field
with modulus Z^2 - 1.

Change History (12)

comment:1 Changed 4 years ago by cheuberg

  • Description modified (diff)

comment:2 Changed 4 years ago by cheuberg

  • Branch set to u/cheuberg/asy/conversion-zero-coefficient

comment:3 Changed 4 years ago by git

  • Commit set to 015922655ae79f9c941f9874974c2eb0097ad574

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

0159226Trac #19921: Handle zero coefficients when converting asymptotic rings

comment:4 Changed 4 years ago by cheuberg

  • Authors set to Clemens Heuberger
  • Status changed from new to needs_review

comment:5 Changed 4 years ago by dkrenn

  • Branch changed from u/cheuberg/asy/conversion-zero-coefficient to u/dkrenn/asy/conversion-zero-coefficient

comment:6 follow-up: Changed 4 years ago by dkrenn

  • Commit changed from 015922655ae79f9c941f9874974c2eb0097ad574 to 25e2348054d9f0674796dca8cbc04f202f00de90

LGTM. I've added one commit; please cross-review and if ok, then set this ticket to positive_review.


New commits:

25e2348use ZeroCoefficientError in create_summand as well

comment:7 Changed 4 years ago by cheuberg

  • Status changed from needs_review to needs_work

This should depend on the new code of mutable_poset.map which allows None and is not merged yet.

comment:8 Changed 4 years ago by cheuberg

  • Branch changed from u/dkrenn/asy/conversion-zero-coefficient to u/cheuberg/asy/conversion-zero-coefficient

comment:9 Changed 4 years ago by cheuberg

  • Commit changed from 25e2348054d9f0674796dca8cbc04f202f00de90 to 3c109a2e942d023ae7dd9ed93665bdc0ac011d15
  • Dependencies set to #19528
  • Status changed from needs_work to needs_review

New commits:

421e377mutable poset map: remove elements ``None``
1d28240term monoid: write change_parameter
2c37889correct a bug in change_parameter
bdcb72bwrite map_coefficients
8a71ba3Trac #19528: simplification of documentation
3c109a2Trac #19921: Merge #19528

comment:10 in reply to: ↑ 6 Changed 4 years ago by cheuberg

  • Authors changed from Clemens Heuberger to Clemens Heuberger, Daniel Krenn
  • Reviewers set to Daniel Krenn, Clemens Heuberger

Replying to dkrenn:

LGTM. I've added one commit; please cross-review and if ok, then set this ticket to positive_review.

Thank you, cross-reviewed. This is a conditional positive modulo #19528.

comment:11 Changed 4 years ago by cheuberg

  • Status changed from needs_review to positive_review

comment:12 Changed 4 years ago by vbraun

  • Branch changed from u/cheuberg/asy/conversion-zero-coefficient to 3c109a2e942d023ae7dd9ed93665bdc0ac011d15
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.