Opened 4 years ago
Closed 4 years ago
#19921 closed defect (fixed)
Handle zero coefficients when converting asymptotic rings
Reported by:  cheuberg  Owned by:  

Priority:  major  Milestone:  sage7.1 
Component:  asymptotic expansions  Keywords:  
Cc:  dkrenn, behackl  Merged in:  
Authors:  Clemens Heuberger, Daniel Krenn  Reviewers:  Daniel Krenn, Clemens Heuberger 
Report Upstream:  N/A  Work issues:  
Branch:  3c109a2 (Commits)  Commit:  3c109a2e942d023ae7dd9ed93665bdc0ac011d15 
Dependencies:  #19528  Stopgaps: 
Description (last modified by )
sage: CR.<Z> = QQ['Z'] sage: CR_mod = CR.quotient((Z^2  1)*CR) sage: R.<x> = AsymptoticRing(growth_group='x^NN', coefficient_ring=CR) sage: R_mod = R.change_parameter(coefficient_ring=CR_mod) sage: e = 1 + x*(Z^21) sage: R_mod(e) Traceback (most recent call last): ... ValueError: Cannot include Z^2  1*x with parent Exact Term Monoid x^((Non negative integer semiring)) with coefficients in Univariate Polynomial Ring in Z over Rational Field in Asymptotic Ring <x^((Non negative integer semiring))> over Univariate Quotient Polynomial Ring in Zbar over Rational Field with modulus Z^2  1 > *previous* ValueError: Zero coefficient 0 is not allowed in Exact Term Monoid x^((Non negative integer semiring)) with coefficients in Univariate Quotient Polynomial Ring in Zbar over Rational Field with modulus Z^2  1.
Change History (12)
comment:1 Changed 4 years ago by
 Description modified (diff)
comment:2 Changed 4 years ago by
 Branch set to u/cheuberg/asy/conversionzerocoefficient
comment:3 Changed 4 years ago by
 Commit set to 015922655ae79f9c941f9874974c2eb0097ad574
comment:4 Changed 4 years ago by
 Status changed from new to needs_review
comment:5 Changed 4 years ago by
 Branch changed from u/cheuberg/asy/conversionzerocoefficient to u/dkrenn/asy/conversionzerocoefficient
comment:6 followup: ↓ 10 Changed 4 years ago by
 Commit changed from 015922655ae79f9c941f9874974c2eb0097ad574 to 25e2348054d9f0674796dca8cbc04f202f00de90
LGTM. I've added one commit; please crossreview and if ok, then set this ticket to positive_review.
New commits:
25e2348  use ZeroCoefficientError in create_summand as well

comment:7 Changed 4 years ago by
 Status changed from needs_review to needs_work
This should depend on the new code of mutable_poset.map
which allows None
and is not merged yet.
comment:8 Changed 4 years ago by
 Branch changed from u/dkrenn/asy/conversionzerocoefficient to u/cheuberg/asy/conversionzerocoefficient
comment:9 Changed 4 years ago by
 Commit changed from 25e2348054d9f0674796dca8cbc04f202f00de90 to 3c109a2e942d023ae7dd9ed93665bdc0ac011d15
 Dependencies set to #19528
 Status changed from needs_work to needs_review
comment:10 in reply to: ↑ 6 Changed 4 years ago by
 Reviewers set to Daniel Krenn, Clemens Heuberger
comment:11 Changed 4 years ago by
 Status changed from needs_review to positive_review
comment:12 Changed 4 years ago by
 Branch changed from u/cheuberg/asy/conversionzerocoefficient to 3c109a2e942d023ae7dd9ed93665bdc0ac011d15
 Resolution set to fixed
 Status changed from positive_review to closed
Note: See
TracTickets for help on using
tickets.
Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:
Trac #19921: Handle zero coefficients when converting asymptotic rings