#19911 closed defect (fixed)
Update to gap4.8.3
Reported by:  vbraun  Owned by:  

Priority:  major  Milestone:  sage7.2 
Component:  group theory  Keywords:  
Cc:  dimpase, fbissey  Merged in:  
Authors:  Dima Pasechnik, Volker Braun  Reviewers:  Dima Pasechnik, Volker Braun 
Report Upstream:  N/A  Work issues:  
Branch:  ba471bc (Commits, GitHub, GitLab)  Commit:  
Dependencies:  Stopgaps: 
Description (last modified by )
GAP 4.8.3 has been released, we got to get it into Sage.
Change History (43)
comment:1 Changed 6 years ago by
comment:2 Changed 6 years ago by
 Branch set to u/vbraun/update_to_gap_4_8_1
comment:3 Changed 6 years ago by
 Commit set to 3539c24f543901959a182a40666f578d1889f511
Branch pushed to git repo; I updated commit sha1. New commits:
3539c24  Update libgap to 4.8.1

comment:4 Changed 6 years ago by
 Commit changed from 3539c24f543901959a182a40666f578d1889f511 to 949d4c2268e3b902d1044a31d4f58164e1dc6c2b
Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:
949d4c2  Update libgap to 4.8.1

comment:5 Changed 6 years ago by
 Commit changed from 949d4c2268e3b902d1044a31d4f58164e1dc6c2b to b9842d48ed1278d4f54b87a7165f69b0fda4f1d2
Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:
b9842d4  Update libgap to 4.8.1

comment:6 Changed 6 years ago by
 Commit changed from b9842d48ed1278d4f54b87a7165f69b0fda4f1d2 to 78586fa8efcd2268920657021187c1e8639c50ef
comment:7 Changed 6 years ago by
 Commit changed from 78586fa8efcd2268920657021187c1e8639c50ef to c2fd7da68b78dc856fc4420d63b2f07118b14bf7
Branch pushed to git repo; I updated commit sha1. New commits:
c2fd7da  Update gap ext code for changed rules for gap

comment:8 Changed 6 years ago by
 Commit changed from c2fd7da68b78dc856fc4420d63b2f07118b14bf7 to c1b5146397b91ec1e93b58eb59e4dd1d8d8bf219
Branch pushed to git repo; I updated commit sha1. New commits:
c1b5146  Update sage code for changed rules for gap identifiers

comment:9 Changed 6 years ago by
 Commit changed from c1b5146397b91ec1e93b58eb59e4dd1d8d8bf219 to f409e06aa3817312f6efc73812bbd6d60e4a094e
comment:10 Changed 6 years ago by
 Cc dimpase added
 Component changed from PLEASE CHANGE to group theory
 Description modified (diff)
 Type changed from PLEASE CHANGE to defect
comment:11 Changed 6 years ago by
 Status changed from new to needs_review
comment:12 Changed 6 years ago by
 Status changed from needs_review to needs_work
lib gap does not build on OSX
... duplicate symbol _libGAP_RealExecStatFuncs in: .libs/libgap_lastats.o .libs/libgap_laprofile.o ld: 1 duplicate symbol for architecture x86_64 collect2: error: ld returned 1 exit status make[4]: *** [libgap.la] Error 1 make[3]: *** [all] Error 2 make[2]: *** [allrecursive] Error 1 Error building libGAP.
comment:13 Changed 6 years ago by
In fact, it's not that we turn something static
into public.
These two things are duly present in the GAP source.
$ grep RealExecStatFuncs * profile.c:UInt (* RealExecStatFuncs[256]) ( Stat stat ); profile.c: RealExecStatFuncs[pos] = stat; profile.c: return RealExecStatFuncs[TNUM_STAT(stat)](stat); profile.c: ExecStatFuncs[i] = RealExecStatFuncs[i]; stats.c:UInt (* RealExecStatFuncs[256]) ( Stat stat ); stats.c: ExecStatFuncs[i] = RealExecStatFuncs[i]; stats.c: RealExecStatFuncs[i] = ExecStatFuncs[i];
comment:14 Changed 6 years ago by
I just opened https://github.com/gapsystem/gap/issues/495 about it.
comment:15 Changed 6 years ago by
 Report Upstream changed from N/A to Reported upstream. Developers acknowledge bug.
comment:16 Changed 6 years ago by
 Commit changed from f409e06aa3817312f6efc73812bbd6d60e4a094e to c4c37d3aa19eee89c80f23ee27ff02e33e270612
Branch pushed to git repo; I updated commit sha1. New commits:
c4c37d3  Fix symbol collision

comment:17 Changed 6 years ago by
 Status changed from needs_work to positive_review
comment:18 Changed 6 years ago by
 Milestone changed from sage7.1 to sagepending
comment:19 Changed 6 years ago by
FYI  GAP is at 4.8.2 http://www.gapsystem.org/Releases/4.8.2.html
comment:20 Changed 6 years ago by
Sure, and there will be 4.8.3 very soon (this month). I'd wait for it...
comment:21 Changed 6 years ago by
 Description modified (diff)
 Milestone changed from sagepending to sage7.2
 Summary changed from Update to gap4.8.1 to Update to gap4.8.3
comment:22 followup: ↓ 23 Changed 6 years ago by
 Status changed from positive_review to needs_info
Do you have a branch for 4.8.3?
comment:23 in reply to: ↑ 22 Changed 6 years ago by
comment:24 Changed 6 years ago by
 Commit changed from c4c37d3aa19eee89c80f23ee27ff02e33e270612 to 5637feaf4f0ad4654dc572924acce593610fce66
Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:
6ebb699  Update to gap4.8.1

caca56c  Delete gap tests that rely on small groups database

b32b693  Update libgap to 4.8.1

cd395d3  Update libgap for ReadEvalCommand api change

48b8bc6  Update gap ext code for changed rules for gap

f53a2e6  Update sage code for changed rules for gap identifiers

e4da4c1  Doctest fixes for changed subgroup generator choices

776b9fb  Doctest fixes for changed GL(6,5) iteration order

b8b01b0  Doctest fixes for changed presentation choice for semidirect product

5637fea  Fix symbol collision

comment:25 Changed 6 years ago by
 Commit changed from 5637feaf4f0ad4654dc572924acce593610fce66 to d933a20f127340a8097357460119fbafcab5ae0d
comment:26 Changed 6 years ago by
 Commit changed from d933a20f127340a8097357460119fbafcab5ae0d to 0cec79e3624f8c8b7f7b6a82c512be155dcd8666
Branch pushed to git repo; I updated commit sha1. New commits:
0cec79e  Doctest fixes for changed GL(6,5) iteration order

comment:27 Changed 6 years ago by
 Status changed from needs_info to needs_review
comment:28 Changed 6 years ago by
 Cc fbissey added
comment:29 Changed 6 years ago by
do you have the tarballs somewhere?
comment:30 Changed 6 years ago by
They are on the mirrors now
comment:31 Changed 6 years ago by
 Status changed from needs_review to needs_work
gap_packages
does not build, as guava version is now 3.13, its patches fail, probably need a review, etc.
comment:32 Changed 6 years ago by
 Branch changed from u/vbraun/update_to_gap_4_8_1 to u/dimpase/gap483_update
 Commit changed from 0cec79e3624f8c8b7f7b6a82c512be155dcd8666 to 789400c2d1f25f6ead5c724b50faf6f9b7ba995a
 Status changed from needs_work to needs_review
comment:33 Changed 6 years ago by
 Status changed from needs_review to needs_work
 Stopgaps set to Hap package is broken
ran ptestlong: got
sage t long warnlong 71.3 src/sage/tests/gap_packages.py ********************************************************************** File "src/sage/tests/gap_packages.py", line 8, in sage.tests.gap_packages Failed example: test_packages(pkgs, only_failures=True) # optional  gap_packages Expected: Status Package GAP Output ++++ Failure HAPcryst fail Got: Status Package GAP Output ++++ Failure HAPcryst fail Failure Hap fail **********************************************************************
and
sage t long warnlong 71.3 src/sage/groups/perm_gps/permgroup.py # 19 doctests failed
all seemingly due to borked Hap.
comment:34 Changed 6 years ago by
The reason for Hap failing is that it depends on CrystCat
in this release, and the latter in turn depends on Cryst
.
These two are GAPcode only, thus trivial to add. Let me do this...
comment:35 Changed 6 years ago by
 Branch changed from u/dimpase/gap483_update to u/vbraun/gap483_update
comment:36 Changed 6 years ago by
 Branch changed from u/vbraun/gap483_update to u/dimpase/gap483_update
Oops hadn't realized you fixed it
comment:37 Changed 6 years ago by
 Branch changed from u/dimpase/gap483_update to u/vbraun/gap483_update
 Commit changed from 789400c2d1f25f6ead5c724b50faf6f9b7ba995a to 7bd659d88630cc1cf125afd412d940f161944c5a
and now gap_packages/spkgsrc does not quite work, as cryst is prefix of crystcat :)
New commits:
7bd659d  Remove obsoleted patches with the guava3.13 update

comment:38 Changed 6 years ago by
 Branch changed from u/vbraun/gap483_update to u/dimpase/gap483_update
 Commit changed from 7bd659d88630cc1cf125afd412d940f161944c5a to d90bafbcac1c693e8b6a2470d31752455d51910a
 Report Upstream changed from Reported upstream. Developers acknowledge bug. to N/A
 Status changed from needs_work to needs_review
 Stopgaps Hap package is broken deleted
fixed tarball:
http://users.ox.ac.uk/~coml0531/sage/gap_packages4.8.3.tar.bz2
New commits:
8dab5ea  Merge branch 'u/vbraun/update_to_gap_4_8_1' of git://trac.sagemath.org/sage into gap483

789400c  bumped up guava version, removed patches (which are now upstream)

2e14875  added cryst, crystcat, aclib, happrime

d90bafb  this should go, too

comment:39 Changed 6 years ago by
 Commit changed from d90bafbcac1c693e8b6a2470d31752455d51910a to ba471bc94f054c201a6967c67fabe91b53db5a99
Branch pushed to git repo; I updated commit sha1. New commits:
ba471bc  slight cleanup

comment:40 Changed 6 years ago by
 Reviewers set to Dima Pasechnik, Volker Braun
 Status changed from needs_review to positive_review
comment:41 Changed 6 years ago by
 Branch changed from u/dimpase/gap483_update to ba471bc94f054c201a6967c67fabe91b53db5a99
 Resolution set to fixed
 Status changed from positive_review to closed
comment:42 Changed 6 years ago by
 Commit ba471bc94f054c201a6967c67fabe91b53db5a99 deleted
Note for a follow up: atlasrep
is in both database_gap
and gap_packages
may be we should decide one way or another which one it belongs too.
comment:43 Changed 6 years ago by
Oups, atlasrep
is in database_gap
's spkgsrc
but is not installed by its spkginstall
. Definitely a follow up ticket.
Duplicate of #19900?