Update to gap-4.8.3

[vbraun]

GAP 4.8.3 has been released, we got to get it into Sage.

[jdemeyer]

Duplicate of #19900?

[git]

Branch pushed to git repo; I updated commit sha1. New commits:

​3539c24

Update libgap to 4.8.1

[git]

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

​949d4c2

Update libgap to 4.8.1

[git]

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

​b9842d4

Update libgap to 4.8.1

[git]

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

​6f01e93	Update libgap to 4.8.1
​78586fa	Update libgap for ReadEvalCommand api change

[git]

Branch pushed to git repo; I updated commit sha1. New commits:

​c2fd7da

Update gap ext code for changed rules for gap

[git]

Branch pushed to git repo; I updated commit sha1. New commits:

​c1b5146

Update sage code for changed rules for gap identifiers

[git]

Branch pushed to git repo; I updated commit sha1. New commits:

​82af259	Doctest fixes for changed subgroup generator choices
​fc7a8d0	Doctest fixes for changed GL(6,5) iteration order
​f409e06	Doctest fixes for changed presentation choice for semidirect product

[dimpase]

lib gap does not build on OSX

...
duplicate symbol _libGAP_RealExecStatFuncs in:
    .libs/libgap_la-stats.o
    .libs/libgap_la-profile.o
ld: 1 duplicate symbol for architecture x86_64
collect2: error: ld returned 1 exit status
make[4]: *** [libgap.la] Error 1
make[3]: *** [all] Error 2
make[2]: *** [all-recursive] Error 1
Error building libGAP.

[dimpase]

In fact, it's not that we turn something static into public. These two things are duly present in the GAP source.

$ grep RealExecStatFuncs *
profile.c:UInt (* RealExecStatFuncs[256]) ( Stat stat );
profile.c:  RealExecStatFuncs[pos] = stat;
profile.c:  return RealExecStatFuncs[TNUM_STAT(stat)](stat);
profile.c:    ExecStatFuncs[i] = RealExecStatFuncs[i];
stats.c:UInt (* RealExecStatFuncs[256]) ( Stat stat );
stats.c:    ExecStatFuncs[i] = RealExecStatFuncs[i];
stats.c:            RealExecStatFuncs[i] = ExecStatFuncs[i];

[dimpase]

I just opened ​https://github.com/gap-system/gap/issues/495 about it.

[git]

Branch pushed to git repo; I updated commit sha1. New commits:

​c4c37d3

Fix symbol collision

[tscrim]

FYI - GAP is at 4.8.2 ​http://www.gap-system.org/Releases/4.8.2.html

[dimpase]

Sure, and there will be 4.8.3 very soon (this month). I'd wait for it...

[vbraun]

Do you have a branch for 4.8.3?

[dimpase]

Replying to vbraun:

Do you have a branch for 4.8.3?

no

[git]

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

​6ebb699	Update to gap-4.8.1
​caca56c	Delete gap tests that rely on small groups database
​b32b693	Update libgap to 4.8.1
​cd395d3	Update libgap for ReadEvalCommand api change
​48b8bc6	Update gap ext code for changed rules for gap
​f53a2e6	Update sage code for changed rules for gap identifiers
​e4da4c1	Doctest fixes for changed subgroup generator choices
​776b9fb	Doctest fixes for changed GL(6,5) iteration order
​b8b01b0	Doctest fixes for changed presentation choice for semidirect product
​5637fea	Fix symbol collision

[git]

Branch pushed to git repo; I updated commit sha1. New commits:

​f4c2f65	Update to gap-4.8.3
​d933a20	Update libgap to 4.8.3

[git]

Branch pushed to git repo; I updated commit sha1. New commits:

​0cec79e

Doctest fixes for changed GL(6,5) iteration order

[dimpase]

do you have the tarballs somewhere?

[vbraun]

They are on the mirrors now

[dimpase]

gap_packages does not build, as guava version is now 3.13, its patches fail, probably need a review, etc.

[dimpase]

here is the guava fix. works now, it seems

---

New commits:

​8dab5ea	Merge branch 'u/vbraun/update_to_gap_4_8_1' of git://trac.sagemath.org/sage into gap483
​789400c	bumped up guava version, removed patches (which are now upstream)

[dimpase]

ran ptestlong: got

sage -t --long --warn-long 71.3 src/sage/tests/gap_packages.py
**********************************************************************
File "src/sage/tests/gap_packages.py", line 8, in sage.tests.gap_packages
Failed example:
    test_packages(pkgs, only_failures=True)    # optional - gap_packages
Expected:
      Status    Package    GAP Output
    +---------+----------+------------+
      Failure   HAPcryst   fail
Got:
      Status    Package    GAP Output
    +---------+----------+------------+
      Failure   HAPcryst   fail
      Failure   Hap        fail
**********************************************************************

and

sage -t --long --warn-long 71.3 src/sage/groups/perm_gps/permgroup.py  # 19 doctests failed

all seemingly due to borked Hap.

[dimpase]

The reason for Hap failing is that it depends on CrystCat in this release, and the latter in turn depends on Cryst.

These two are GAP-code only, thus trivial to add. Let me do this...

[vbraun]

Oops hadn't realized you fixed it

[dimpase]

and now gap_packages/spkg-src does not quite work, as cryst is prefix of crystcat :-)

---

New commits:

​7bd659d

Remove obsoleted patches with the guava-3.13 update

[dimpase]

fixed tarball:

​http://users.ox.ac.uk/~coml0531/sage/gap_packages-4.8.3.tar.bz2

---

New commits:

​8dab5ea	Merge branch 'u/vbraun/update_to_gap_4_8_1' of git://trac.sagemath.org/sage into gap483
​789400c	bumped up guava version, removed patches (which are now upstream)
​2e14875	added cryst, crystcat, aclib, happrime
​d90bafb	this should go, too

[git]

Branch pushed to git repo; I updated commit sha1. New commits:

​ba471bc

slight cleanup

[fbissey]

Note for a follow up: atlasrep is in both database_gap and gap_packages may be we should decide one way or another which one it belongs too.

[fbissey]

Oups, atlasrep is in database_gap's spkg-src but is not installed by its spkg-install. Definitely a follow up ticket.