Upgrade PARI/GP to latest master

[buck]

Tarball: ​http://sage.ugent.be/www/jdemeyer/sage/pari-2.8-2308-gd228ed3.tar.gz

[buck]

This is what I have so far, but I see that src/sage/libs/pari/paridecl.pxd needs to be updated. @jdemeyer: How is this file maintained? I don't trust my ability to do this accurately, manually. It seems like something that should also be done by the autogen/pari system.

build/pkgs/pari/checksums.ini

@@ -1 +1 @@
 tarball=pari-VERSION.tar.gz
-sha1=fa23e0c8b6e38a356048d19224dc9b9658d77724
-md5=c753faaa4780de5ad8d461f0ffd70ecf
-cksum=1220765312
+sha1=55299bfe042da491648897e830030083809d9967
+md5=97738f8e92bba498f7dfd723c8e9d910
+cksum=1221580104

build/pkgs/pari/package-version.txt

@@ -1 @@
-2.8-1813-g6157df4.p0
+2.8-2230-g450ce38

build/pkgs/pari/patches/public_memory_functions.patch

@@ -9 +9 @@
 +void *  pari_mainstack_malloc(size_t size);
 +void    pari_mainstack_mfree(void *s, size_t size);
 +void    pari_mainstack_free(struct pari_mainstack *st);
- void    paristack_alloc(size_t rsize, size_t vsize);
  void    paristack_newrsize(ulong newsize);
  void    paristack_resize(ulong newsize);
+ void    paristack_setsize(size_t rsize, size_t vsize);
 diff --git a/src/language/init.c b/src/language/init.c
 index 7b5922d..2a578d7 100644
 --- a/src/language/init.c

src/sage_setup/autogen/pari/args.py

@@ -254 +254 @@
         s = "        {name} = prec_bits_to_words({name})\n"
         return s.format(name=self.name)
 
+class PariArgumentBitPrec(PariArgumentClass):
+    def _typerepr(self):
+        return "bitprec"
+    def ctype(self):
+        return "long"
+    def always_default(self):
+        return "0"
+    def get_argument_name(self, namesiter):
+        return "bitprecision"
+
 class PariArgumentSeriesPrec(PariArgumentClass):
     def _typerepr(self):
         return "serprec"
@@ -277 +287 @@
         'U': PariArgumentULong,
         'n': PariArgumentVariable,
         'p': PariArgumentPrec,
+        'b': PariArgumentBitPrec,
         'P': PariArgumentSeriesPrec,
 
     # Codes which are known but not actually supported for Sage

src/sage_setup/autogen/pari/generator.py

@@ -233 +233 @@
         D = sorted(D.values(), key=lambda d: d['function'])
         sys.stdout.write("Generating PARI functions:")
 
-        self.gen_file = open(self.gen_filename, 'w')
+        self.gen_file = open(self.gen_filename + '.tmp', 'w')
         self.gen_file.write(gen_banner)
-        self.instance_file = open(self.instance_filename, 'w')
+        self.instance_file = open(self.instance_filename + '.tmp', 'w')
         self.instance_file.write(instance_banner)
 
         for v in D:
@@ -249 +249 @@
 
         self.gen_file.close()
         self.instance_file.close()
+
+        # All done? Let's commit.
+        os.rename(self.gen_filename + '.tmp', self.gen_filename)
+        os.rename(self.instance_filename + '.tmp', self.instance_filename)

[jdemeyer]

Replying to buck:

This is what I have so far, but I see that src/sage/libs/pari/paridecl.pxd needs to be updated. @jdemeyer: How is this file maintained?

Manually. It's mostly a copy and paste from PARI's <paridecl.h>.

It seems like something that should also be done by the autogen/pari system.

Feel free to propose a patch :-)

I would prefer this ticket to depend on #19883 in order to avoid merge conflicts.

[jdemeyer]

A reviewer without author?

[buck]

New commits:

​683ac86

update pari to latest master

[jdemeyer]

You should write your real name in the Author field.

Also don't forget to post a link to the tarball (created with make snapshot) and to set the ticket to needs_review if you are done.

[jdemeyer]

What does the "Fixed upstream, but not in a stable release." refer to?

[jdemeyer]

@buck: do you intend to finish this?

[jdemeyer]

@buck: I will finish this. Remember to add your real name as author.

[git]

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

​cf197b7

Merge tag '7.1.beta1' into t/19905/bump-pari

[git]

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

​b92232c	Merge tag '7.1.beta1' into t/19905/bump-pari
​e36e614	Remove obsolete declarations
​7d9387a	Fix bitprec support

[git]

Branch pushed to git repo; I updated commit sha1. New commits:

​5bca083

Add pari_stack declarations

[buck]

LGTM.

Thanks for finishing up. I hope my patch helped some.

[jdemeyer]

Replying to buck:

I hope my patch helped some.

Of course it did. Thank you too.