Opened 5 years ago
Closed 5 years ago
#19905 closed enhancement (fixed)
Upgrade PARI/GP to latest master
Reported by: | buck | Owned by: | buck |
---|---|---|---|
Priority: | major | Milestone: | sage-7.1 |
Component: | packages: standard | Keywords: | |
Cc: | rws | Merged in: | |
Authors: | Buck Evan, Jeroen Demeyer | Reviewers: | Buck Evan |
Report Upstream: | N/A | Work issues: | |
Branch: | 5bca083 (Commits, GitHub, GitLab) | Commit: | 5bca083d3e391ced1170fb7e7be79a747a899310 |
Dependencies: | Stopgaps: |
Description (last modified by )
Change History (22)
comment:1 follow-up: ↓ 2 Changed 5 years ago by
- Cc rws added
- Component changed from PLEASE CHANGE to packages: standard
- Reviewers set to jdemeyer
comment:2 in reply to: ↑ 1 Changed 5 years ago by
Replying to buck:
This is what I have so far, but I see that
src/sage/libs/pari/paridecl.pxd
needs to be updated. @jdemeyer: How is this file maintained?
Manually. It's mostly a copy and paste from PARI's <paridecl.h>
.
It seems like something that should also be done by the autogen/pari system.
Feel free to propose a patch :-)
I would prefer this ticket to depend on #19883 in order to avoid merge conflicts.
comment:3 Changed 5 years ago by
- Reviewers jdemeyer deleted
- Type changed from PLEASE CHANGE to enhancement
A reviewer without author?
comment:4 Changed 5 years ago by
- Dependencies set to #19883
comment:5 Changed 5 years ago by
- Branch set to u/buck/bump-pari
comment:6 Changed 5 years ago by
- Commit set to 683ac866ce855a27ed436b199327c8525c1ac565
- Owner changed from (none) to buck
- Report Upstream changed from N/A to Fixed upstream, but not in a stable release.
- Reviewers set to jdemeyer
New commits:
683ac86 | update pari to latest master
|
comment:7 Changed 5 years ago by
- Reviewers changed from jdemeyer to Jeroen Demeyer
You should write your real name in the Author field.
Also don't forget to post a link to the tarball (created with make snapshot
) and to set the ticket to needs_review
if you are done.
comment:8 Changed 5 years ago by
- Description modified (diff)
- Milestone changed from sage-7.0 to sage-7.1
What does the "Fixed upstream, but not in a stable release." refer to?
comment:9 Changed 5 years ago by
@buck: do you intend to finish this?
comment:10 Changed 5 years ago by
- Reviewers Jeroen Demeyer deleted
@buck: I will finish this. Remember to add your real name as author.
comment:11 Changed 5 years ago by
- Report Upstream changed from Fixed upstream, but not in a stable release. to N/A
comment:12 Changed 5 years ago by
- Description modified (diff)
comment:13 Changed 5 years ago by
- Branch changed from u/buck/bump-pari to u/jdemeyer/bump-pari
comment:14 Changed 5 years ago by
- Commit changed from 683ac866ce855a27ed436b199327c8525c1ac565 to cf197b7b8ca9885ed81b40961caaa6ce059558ce
Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:
cf197b7 | Merge tag '7.1.beta1' into t/19905/bump-pari
|
comment:15 Changed 5 years ago by
- Dependencies #19883 deleted
comment:16 Changed 5 years ago by
- Description modified (diff)
comment:17 Changed 5 years ago by
- Commit changed from cf197b7b8ca9885ed81b40961caaa6ce059558ce to 7d9387a2b2d2d88cd0603f34a065b03ddfd0bdf4
comment:18 Changed 5 years ago by
- Commit changed from 7d9387a2b2d2d88cd0603f34a065b03ddfd0bdf4 to 5bca083d3e391ced1170fb7e7be79a747a899310
Branch pushed to git repo; I updated commit sha1. New commits:
5bca083 | Add pari_stack declarations
|
comment:19 Changed 5 years ago by
- Status changed from new to needs_review
comment:20 follow-up: ↓ 21 Changed 5 years ago by
- Reviewers set to Buck Evan
- Status changed from needs_review to positive_review
LGTM.
Thanks for finishing up. I hope my patch helped some.
comment:21 in reply to: ↑ 20 Changed 5 years ago by
comment:22 Changed 5 years ago by
- Branch changed from u/jdemeyer/bump-pari to 5bca083d3e391ced1170fb7e7be79a747a899310
- Resolution set to fixed
- Status changed from positive_review to closed
This is what I have so far, but I see that
src/sage/libs/pari/paridecl.pxd
needs to be updated. @jdemeyer: How is this file maintained? I don't trust my ability to do this accurately, manually. It seems like something that should also be done by the autogen/pari system.build/pkgs/pari/checksums.ini
fa23e0c8b6e38a356048d19224dc9b9658d77724c753faaa4780de5ad8d461f0ffd70ecf0765312build/pkgs/pari/package-version.txt
1813-g6157df4.p0build/pkgs/pari/patches/public_memory_functions.patch
void paristack_alloc(size_t rsize, size_t vsize);src/sage_setup/autogen/pari/args.py
src/sage_setup/autogen/pari/generator.py
, 'w'), 'w')