Opened 3 years ago

Closed 3 years ago

#19903 closed defect (fixed)

crash with MIP_Problem

Reported by: vdelecroix Owned by:
Priority: critical Milestone: sage-7.2
Component: linear programming Keywords:
Cc: vbraun Merged in:
Authors: Vincent Delecroix Reviewers: Volker Braun, Matthias Koeppe
Report Upstream: N/A Work issues:
Branch: f0c0346 (Commits) Commit: f0c0346fd6ded2232401125b828a04364f2fb354
Dependencies: Stopgaps:

Description

The following crashes Sage

sage: from sage.libs.ppl import Variable, Constraint_System, MIP_Problem
sage: x = Variable(0)
sage: y = Variable(1)
sage: cs = Constraint_System()
sage: cs.insert(x + y <= 2)
sage: MIP_Problem(2, cs, 0)
...
Unhandled SIGSEGV: A segmentation fault occurred in Sage.

If we replace 0 by x or y it also crashes... but with x-x or x+y or x+0it is fine!

This is just a problem of types.

Change History (9)

comment:1 Changed 3 years ago by vdelecroix

  • Branch set to u/vdelecroix/19903
  • Commit set to d22dbfaca76edbb4f71510065728b83df694347d

New commits:

d22dbfaTrac 19903: fix MIP_Problem constructor

comment:2 Changed 3 years ago by vbraun

cdef attribute initialization should be done from __cinit__, not __init__

comment:3 Changed 3 years ago by git

  • Commit changed from d22dbfaca76edbb4f71510065728b83df694347d to 980f1253ba5c527aeaa4c063f9d981752bb60ffe

Branch pushed to git repo; I updated commit sha1. New commits:

980f125Trac 19903: add a 'c'

comment:4 Changed 3 years ago by vbraun

lgtm

comment:5 Changed 3 years ago by mkoeppe

  • Reviewers set to Volker Braun

Patch no longer applies to current Sage, needs rebasing.

comment:6 Changed 3 years ago by git

  • Commit changed from 980f1253ba5c527aeaa4c063f9d981752bb60ffe to f0c0346fd6ded2232401125b828a04364f2fb354

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

f0c0346Trac 19903: fix MIP_Problem constructor

comment:7 Changed 3 years ago by vdelecroix

  • Milestone changed from sage-7.0 to sage-7.2
  • Status changed from new to needs_review

comment:8 Changed 3 years ago by mkoeppe

  • Reviewers changed from Volker Braun to Volker Braun, Matthias Koeppe
  • Status changed from needs_review to positive_review

comment:9 Changed 3 years ago by vbraun

  • Branch changed from u/vdelecroix/19903 to f0c0346fd6ded2232401125b828a04364f2fb354
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.