Opened 5 years ago
Last modified 5 years ago
#19902 needs_work enhancement
Warn if dependencies are unsatisfied
Reported by: | vbraun | Owned by: | |
---|---|---|---|
Priority: | minor | Milestone: | sage-7.0 |
Component: | build | Keywords: | |
Cc: | Merged in: | ||
Authors: | Volker Braun, Jeroen Demeyer | Reviewers: | Jeroen Demeyer |
Report Upstream: | N/A | Work issues: | |
Branch: | u/jdemeyer/warn_if_dependencies_are_unsatisfied (Commits) | Commit: | 0e013a1d6264c51113e82add1ba44fc327320fce |
Dependencies: | #19843 | Stopgaps: |
Description
Say you have a package A depending on B and you decide to (re)build B. Then you should also rebuild A before running Sage. For example:
echo "Warning: it might be needed to update the Sage library before" echo "installed packages work: you should run 'make' from \$SAGE_ROOT" echo "before running Sage."
Implementation suggestions:
- print that warning simply after
make B
- use
make --question
Change History (7)
comment:1 Changed 5 years ago by
- Dependencies set to #19843
- Priority changed from major to blocker
comment:2 Changed 5 years ago by
- Priority changed from blocker to minor
comment:3 Changed 5 years ago by
- Branch set to u/vbraun/warn_if_dependencies_are_unsatisfied
comment:4 Changed 5 years ago by
- Commit set to 50ba4fefe079d750b83138b80b157561a85f7240
- Reviewers set to Jeroen Demeyer
- Status changed from new to needs_review
comment:5 Changed 5 years ago by
- Branch changed from u/vbraun/warn_if_dependencies_are_unsatisfied to u/jdemeyer/warn_if_dependencies_are_unsatisfied
comment:6 Changed 5 years ago by
- Commit changed from 50ba4fefe079d750b83138b80b157561a85f7240 to 0e013a1d6264c51113e82add1ba44fc327320fce
I think it's slightly better to put the message in build/make/install
such that it appears as very last message when the user installs a package.
New commits:
0e013a1 | Suggest to run 'make' after building a package
|
comment:7 Changed 5 years ago by
- Status changed from needs_review to needs_work
Merge conflict with your own commit, can you fix it?
Note: See
TracTickets for help on using
tickets.
Informational messages aren't blockers