Opened 4 years ago

Closed 4 years ago

#19898 closed enhancement (fixed)

AsymptoticExpansion: Generator for expansion of harmonic number

Reported by: cheuberg Owned by:
Priority: major Milestone: sage-7.1
Component: asymptotic expansions Keywords: generator, harmonic number
Cc: dkrenn, behackl Merged in:
Authors: Clemens Heuberger Reviewers: Daniel Krenn
Report Upstream: N/A Work issues:
Branch: 95762d4 (Commits) Commit: 95762d4126a3a7f5ab44b401dd80a314f7934fec
Dependencies: #19510 Stopgaps:

Description (last modified by cheuberg)

Implement asymptotic_expansions.HarmonicNumber.

Change History (17)

comment:1 Changed 4 years ago by cheuberg

  • Branch set to u/cheuberg/asy/harmonic-number

comment:2 Changed 4 years ago by git

  • Commit set to adae74b3ce2d743b6cfb47a30f59a1f2d7c0bd08

Branch pushed to git repo; I updated commit sha1. Last 10 new commits:

1d28240term monoid: write change_parameter
2c37889correct a bug in change_parameter
bdcb72bwrite map_coefficients
2a0815dMerge branch 'asy/map_coefficients' into asy/generators-binomial
e93ce46simplify coefficients automatically and use the faster algorithm per default
f468de6docu
4a27e66result over QQ if skip-parameter given
e59c71ftoc entry (at top of file)
ea3dd35small bugfix
adae74bTrac #19898: Merge #19510 to resolve conflicts

comment:3 Changed 4 years ago by cheuberg

  • Dependencies set to #19510
  • Status changed from new to needs_review

comment:4 Changed 4 years ago by git

  • Commit changed from adae74b3ce2d743b6cfb47a30f59a1f2d7c0bd08 to e193ac147ddee630924adfd46f3fc7043c1b2cad

Branch pushed to git repo; I updated commit sha1. New commits:

eac4977Trac #19306: minor changes (cross-review and incorporate reviewer comments)
946a828Trac #19306: change % to .format
809d653Trac #19306: Merge tag '7.0' due to #19879
4d80eb3Trac #19306: sage.rings.arith -> sage.arith.all (after #19879)
ef9cb08Trac #19898: Merge #19306 (due to #19879)
e193ac1Trac #19898: sage.rings.arith -> sage.arith.all (after #19879)

comment:5 Changed 4 years ago by git

  • Commit changed from e193ac147ddee630924adfd46f3fc7043c1b2cad to bedd23ae89d2e1d7be6b3016ea4fc7446ccf71ab

Branch pushed to git repo; I updated commit sha1. New commits:

bedd23aTrac #19898: rename harmonic_number to HarmonicNumber

comment:6 Changed 4 years ago by dkrenn

  • Reviewers set to Daniel Krenn

LGTM; this ticket can go to positive once its dependency is positive.

comment:7 follow-up: Changed 4 years ago by git

  • Commit changed from bedd23ae89d2e1d7be6b3016ea4fc7446ccf71ab to 27e9e6992fadf8c8489805b8247465a3200e42ef

Branch pushed to git repo; I updated commit sha1. New commits:

27e9e69Trac #19898: state constant summand in documentation

comment:8 Changed 4 years ago by cheuberg

  • Description modified (diff)
  • Milestone changed from sage-7.0 to sage-7.1

comment:9 in reply to: ↑ 7 Changed 4 years ago by dkrenn

Replying to git:

Branch pushed to git repo; I updated commit sha1. New commits:

27e9e69Trac #19898: state constant summand in documentation

Cross-review done...ok.

comment:10 Changed 4 years ago by dkrenn

  • Branch changed from u/cheuberg/asy/harmonic-number to u/dkrenn/asy/harmonic-number

comment:11 Changed 4 years ago by dkrenn

  • Commit changed from 27e9e6992fadf8c8489805b8247465a3200e42ef to 209329d949ee890c2da56c09c4066422bd06c4a2

Merged in #19510 due to changes there and conflicts here.


Last 10 new commits:

24c153cTrac #19946: reviewer commit: ReSt error
7918417Trac #19946: additional doctest
1471336Trac #19946: rewrite and improve explaination of 1b62954
9f9a23fTrac #19961: document rpow
101e4deMerge branch 'u/dkrenn/t/19961' of trac.sagemath.org:sage into t/19946
7179c78Trac #19946: link from general doc to detailed explaination
1259201Trac #19946: fix typo
37caf25Merge branch 'u/cheuberg/t/19946' of trac.sagemath.org:sage into t/19510/asy/generators-binomial
10cd04bTrac #19510: major rewrite of binomial kn over n
209329dMerge branch 'u/dkrenn/asy/generators-binomial' of trac.sagemath.org:sage into t/19898/asy/harmonic-number

comment:12 Changed 4 years ago by cheuberg

  • Branch changed from u/dkrenn/asy/harmonic-number to u/cheuberg/asy/harmonic-number

comment:13 Changed 4 years ago by dkrenn

  • Commit changed from 209329d949ee890c2da56c09c4066422bd06c4a2 to a66c377dd79d4b0f11d32c3f6764c989e830aedb
  • Status changed from needs_review to positive_review

New commits:

00eae5dMerge branch 't/19957/asy/compare-with-values' into t/19510/asy/generators-binomial
78bdd0fTrac #19510: additional doctests using compare_with_values
148eabbTrac #19898: Merge #19510
a66c377Trac #19898: additional doctest using compare_with_values

comment:14 Changed 4 years ago by git

  • Commit changed from a66c377dd79d4b0f11d32c3f6764c989e830aedb to 95762d4126a3a7f5ab44b401dd80a314f7934fec
  • Status changed from positive_review to needs_review

Branch pushed to git repo; I updated commit sha1 and set ticket back to needs_review. New commits:

95762d4Trac #19898: add relative tolerance to doctests introduced on this ticket

comment:15 follow-up: Changed 4 years ago by cheuberg

sorry, had forgotten to push this last commit with relative tolerances.

comment:16 in reply to: ↑ 15 Changed 4 years ago by dkrenn

  • Status changed from needs_review to positive_review

Replying to cheuberg:

sorry, had forgotten to push this last commit with relative tolerances.

comment:17 Changed 4 years ago by vbraun

  • Branch changed from u/cheuberg/asy/harmonic-number to 95762d4126a3a7f5ab44b401dd80a314f7934fec
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.