Opened 6 years ago

Closed 6 years ago

#19888 closed enhancement (fixed)

Move gen_py.python to gen.pyx

Reported by: jdemeyer Owned by:
Priority: major Milestone: sage-7.0
Component: interfaces Keywords:
Cc: Merged in:
Authors: Jeroen Demeyer Reviewers: Volker Braun
Report Upstream: N/A Work issues:
Branch: 581fc93 (Commits, GitHub, GitLab) Commit: 581fc93b63782a0b5dfe3d9de9e93e13e52c47bd
Dependencies: Stopgaps:

Status badges

Description (last modified by jdemeyer)

There is no reason for gen_py.py to be a separate file. We move the function python() to a cpdef function gentoobj() (mirroring the already existing function objtogen()).

Change History (9)

comment:1 Changed 6 years ago by jdemeyer

  • Description modified (diff)
  • Summary changed from Move gen_py.python into the gen class to Move gen_py.python to gen.pyx

comment:2 Changed 6 years ago by jdemeyer

  • Branch set to u/jdemeyer/ticket/19888

comment:3 Changed 6 years ago by git

  • Commit set to 6da8af960dd5a2023631e34dcdf4be7029009e8d

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

​6da8af9Move gen_py.python to gen.pyx

comment:4 Changed 6 years ago by jdemeyer

  • Status changed from new to needs_review

comment:5 Changed 6 years ago by jdemeyer

  • Status changed from needs_review to needs_work

comment:6 Changed 6 years ago by git

  • Commit changed from 6da8af960dd5a2023631e34dcdf4be7029009e8d to 581fc93b63782a0b5dfe3d9de9e93e13e52c47bd

Branch pushed to git repo; I updated commit sha1. New commits:

​581fc93Fix doctest failures

comment:7 Changed 6 years ago by jdemeyer

  • Status changed from needs_work to needs_review

comment:8 Changed 6 years ago by vbraun

  • Reviewers set to Volker Braun
  • Status changed from needs_review to positive_review

comment:9 Changed 6 years ago by vbraun

  • Branch changed from u/jdemeyer/ticket/19888 to 581fc93b63782a0b5dfe3d9de9e93e13e52c47bd
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.