Opened 4 years ago

Closed 3 years ago

#19881 closed enhancement (fixed)

Allow Mac App to run both notebook versions

Reported by: iandrus Owned by:
Priority: critical Milestone: sage-7.0
Component: user interface Keywords: mac app
Cc: kcrisman Merged in:
Authors: Ivan Andrus Reviewers: Volker Braun
Report Upstream: N/A Work issues:
Branch: 56af15e (Commits) Commit: 56af15e5fa396822ea9975220aa64fcde79b1f90
Dependencies: Stopgaps:

Description

We need to support running both sagenb and ipynb notebooks. Moreover, we need to support exporting sagenb to ipynb to ease the transition. Auto-detection of existing sagenb notebooks and smartly offering to upgrade would be nice as well.

Change History (11)

comment:1 Changed 4 years ago by iandrus

  • Dependencies set to #19877, #19740

comment:2 Changed 4 years ago by iandrus

  • Authors set to Ivan Andrus
  • Branch set to u/iandrus/mac-app-default-notebook
  • Commit set to 19d479354cc015b5ee6d24eb389d0531315671ef

Here's a first pass. I haven't tested the export functionality, which requires #19877. Other than that the ability to choose which notebook to use is there and should work correctly.


New commits:

7eeb2a4Fix warnings
401f13bUpdate AppleScript for iTerm v3
5ac2c1aAutomatically offer to upgrade
202b87bAdd support for opening Jupyter notebooks
42933a0Remove bdist menus (#20164)
69f899bGrab the Jupyter URL so we can open it later
19d4793Remove trailing whitespace that creeped in

comment:3 Changed 4 years ago by kcrisman

Is this branch red due to #20119? See also #20189.

comment:4 Changed 4 years ago by git

  • Commit changed from 19d479354cc015b5ee6d24eb389d0531315671ef to eb3c96b99f8415247c69ea47bb6d6fd2472aaf93

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

4b42730Fix warnings
598cc87Update AppleScript for iTerm v3
3857cb6Automatically offer to upgrade
d547cceAdd support for opening Jupyter notebooks
f799a2cRemove bdist menus (#20164)
e7f3e22Grab the Jupyter URL so we can open it later
7a9c3c0Remove trailing whitespace that creeped in
eb3c96b(BAD) Open scripts in another directory

comment:5 Changed 4 years ago by git

  • Commit changed from eb3c96b99f8415247c69ea47bb6d6fd2472aaf93 to 7a9c3c056bf71cf6c43d80dc6168af168fcd42e8

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

comment:6 Changed 4 years ago by iandrus

I rebased on develop. The conflict was actually with #20164.

comment:7 Changed 4 years ago by iandrus

  • Dependencies changed from #19877, #19740 to #19877

comment:8 Changed 3 years ago by git

  • Commit changed from 7a9c3c056bf71cf6c43d80dc6168af168fcd42e8 to 56af15e5fa396822ea9975220aa64fcde79b1f90

Branch pushed to git repo; I updated commit sha1. New commits:

56af15eRemove dependency on export notebook

comment:9 Changed 3 years ago by iandrus

  • Dependencies #19877 deleted
  • Status changed from new to needs_review

I removed the dependency on #19877, since there wasn't a good reason for it to be there. I opened #20316 to add it back.

comment:10 Changed 3 years ago by vbraun

  • Reviewers set to Volker Braun
  • Status changed from needs_review to positive_review

comment:11 Changed 3 years ago by vbraun

  • Branch changed from u/iandrus/mac-app-default-notebook to 56af15e5fa396822ea9975220aa64fcde79b1f90
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.