Opened 6 years ago

Closed 6 years ago

#19874 closed enhancement (fixed)

Configure NTL without NTL_LEGACY_SP_MULMOD=on

Reported by: jpflori Owned by:
Priority: major Milestone: sage-7.0
Component: packages: standard Keywords: ntl
Cc: jdemeyer Merged in:
Authors: Jean-Pierre Flori Reviewers: Jeroen Demeyer
Report Upstream: N/A Work issues:
Branch: b0071e0 (Commits, GitHub, GitLab) Commit: b0071e0b2501628a4f31f7bfe53ec1079c6223c8
Dependencies: Stopgaps:

Status badges

Description (last modified by jpflori)

There is an issue with bernmm which prevents this. For every even number from 128, the result of

bernoulli(n, algorithm='bernmm')

is wrong.

This is because some modular multiplication mod n is made with inputs larger than n which is not supported by NTL (as documented).

Change History (7)

comment:1 Changed 6 years ago by jpflori

  • Authors set to Jean-Pierre Flori
  • Branch set to u/jpflori/ticket/19874
  • Cc jdemeyer added
  • Commit set to b868e2902d760518fe039bf8d9e3c5e4a5403a30
  • Description modified (diff)
  • Keywords ntl added
  • Status changed from new to needs_review

New commits:

b868e29Use new NTL sp_mulmod code.

comment:2 Changed 6 years ago by jdemeyer

  • Status changed from needs_review to needs_work

NTL version number should be increased.

comment:3 Changed 6 years ago by git

  • Commit changed from b868e2902d760518fe039bf8d9e3c5e4a5403a30 to 34d91489169c821d3015cfe8529e6ac3b4177cff

Branch pushed to git repo; I updated commit sha1. New commits:

f711459Bump NTL version to force a rebuild.
34d9148Add additional minimal previously failing test for new NTL + unmodified bernmm.

comment:4 Changed 6 years ago by jpflori

  • Status changed from needs_work to needs_review

comment:5 Changed 6 years ago by git

  • Commit changed from 34d91489169c821d3015cfe8529e6ac3b4177cff to b0071e0b2501628a4f31f7bfe53ec1079c6223c8

Branch pushed to git repo; I updated commit sha1. New commits:

b0071e0Fix indentation of NTL+bernmm test.

comment:6 Changed 6 years ago by jdemeyer

  • Reviewers set to Jeroen Demeyer
  • Status changed from needs_review to positive_review

comment:7 Changed 6 years ago by vbraun

  • Branch changed from u/jpflori/ticket/19874 to b0071e0b2501628a4f31f7bfe53ec1079c6223c8
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.