Opened 6 years ago

Closed 6 years ago

#19856 closed enhancement (fixed)

new plot function hyperbolic_regular_polygon()

Reported by: jhonrubia6 Owned by: jhonrubia6
Priority: minor Milestone: sage-7.1
Component: graphics Keywords: hyperbolic geometry plot
Cc: Merged in:
Authors: Javier Honrubia González Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: 7c0416e (Commits, GitHub, GitLab) Commit: 7c0416ea44b5bf73b671e36ba2f5b76b9f301fc4
Dependencies: Stopgaps:

Status badges

Description (last modified by jhonrubia6)

A new plotting function on the upper half model of Hyperbolic Plane for a regular polygon given: *Interior angles (required) *Number of sides (required) *Center of the polygon (default = 0+I)

The function should detect if the polygon exists for the interior angles and number of sides combination given.

Attachments (1)

hyperbolic_regular_polygon.py (11.4 KB) - added by jhonrubia6 6 years ago.

Download all attachments as: .zip

Change History (15)

comment:1 Changed 6 years ago by jhonrubia6

  • Component changed from PLEASE CHANGE to graphics
  • Description modified (diff)
  • Keywords hyperbolic geometry plot added
  • Owner changed from (none) to jhonrubia6
  • Priority changed from major to minor
  • Type changed from PLEASE CHANGE to enhancement

comment:2 Changed 6 years ago by jhonrubia6

  • Authors set to jhonrubia6

comment:3 Changed 6 years ago by jhonrubia6

  • Branch set to t/19856/new_plot_function_hyperbolic_regular_polygon__

comment:4 Changed 6 years ago by jhonrubia6

  • Branch changed from t/19856/new_plot_function_hyperbolic_regular_polygon__ to u/jhonrubia6/new_plot_function_hyperbolic_regular_polygon__

comment:5 Changed 6 years ago by jhonrubia6

  • Branch changed from u/jhonrubia6/new_plot_function_hyperbolic_regular_polygon__ to u/jhonrubia6/new_plot_function_hyperbolic_regular_polygon

comment:6 Changed 6 years ago by jhonrubia6

  • Branch changed from u/jhonrubia6/new_plot_function_hyperbolic_regular_polygon to t/19856/new_plot_function_hyperbolic_regular_polygon__

comment:7 Changed 6 years ago by jhonrubia6

  • Branch changed from t/19856/new_plot_function_hyperbolic_regular_polygon__ to t/19856/new_plot_function_hyperbolic_regular_polygon

Changed 6 years ago by jhonrubia6

comment:8 Changed 6 years ago by jhonrubia6

  • Authors changed from jhonrubia6 to Javier Honrubia González

comment:9 Changed 6 years ago by jhonrubia6

  • Branch changed from t/19856/new_plot_function_hyperbolic_regular_polygon to u/jhonrubia6/new_plot_function_hyperbolic_regular_polygon

comment:10 Changed 6 years ago by jhonrubia6

  • Commit set to 1375c98c4d72c92db87c7515d4d1f86aaa5af175
  • Status changed from new to needs_review

New commits:

1375c98Function hiperbolic_regular_polygon created to plot a compact regular hyperbolic polygons given the number of sides, interior angle and optionally an hyperbolic center.

comment:11 Changed 6 years ago by jhonrubia6

  • Milestone changed from sage-7.0 to sage-7.1

comment:12 Changed 6 years ago by tscrim

  • Branch changed from u/jhonrubia6/new_plot_function_hyperbolic_regular_polygon to public/graphics/plot_hyperbolic_regular_polygon-19856
  • Commit changed from 1375c98c4d72c92db87c7515d4d1f86aaa5af175 to 7c0416ea44b5bf73b671e36ba2f5b76b9f301fc4
  • Reviewers set to Travis Scrimshaw

Looks good overall. I made some reviewer changes. If you agree with them, then please set this to positive review. Thanks.


New commits:

53a4fe0Merge branch 'u/jhonrubia6/new_plot_function_hyperbolic_regular_polygon' of trac.sagemath.org:sage into public/graphics/plot_hyperbolic_regular_polygon-19856
7c0416eReviewer changes to hyperbolic regular polygon plotting.

comment:13 Changed 6 years ago by jhonrubia6

  • Status changed from needs_review to positive_review

Thank you for making the changes. It looks good to me. On behalf of your comment I change the status to positive review

comment:14 Changed 6 years ago by vbraun

  • Branch changed from public/graphics/plot_hyperbolic_regular_polygon-19856 to 7c0416ea44b5bf73b671e36ba2f5b76b9f301fc4
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.