Opened 6 years ago
Closed 6 years ago
#19856 closed enhancement (fixed)
new plot function hyperbolic_regular_polygon()
Reported by:  jhonrubia6  Owned by:  jhonrubia6 

Priority:  minor  Milestone:  sage7.1 
Component:  graphics  Keywords:  hyperbolic geometry plot 
Cc:  Merged in:  
Authors:  Javier Honrubia González  Reviewers:  Travis Scrimshaw 
Report Upstream:  N/A  Work issues:  
Branch:  7c0416e (Commits, GitHub, GitLab)  Commit:  7c0416ea44b5bf73b671e36ba2f5b76b9f301fc4 
Dependencies:  Stopgaps: 
Description (last modified by )
A new plotting function on the upper half model of Hyperbolic Plane for a regular polygon given: *Interior angles (required) *Number of sides (required) *Center of the polygon (default = 0+I)
The function should detect if the polygon exists for the interior angles and number of sides combination given.
Attachments (1)
Change History (15)
comment:1 Changed 6 years ago by
 Component changed from PLEASE CHANGE to graphics
 Description modified (diff)
 Keywords hyperbolic geometry plot added
 Owner changed from (none) to jhonrubia6
 Priority changed from major to minor
 Type changed from PLEASE CHANGE to enhancement
comment:2 Changed 6 years ago by
comment:3 Changed 6 years ago by
 Branch set to t/19856/new_plot_function_hyperbolic_regular_polygon__
comment:4 Changed 6 years ago by
 Branch changed from t/19856/new_plot_function_hyperbolic_regular_polygon__ to u/jhonrubia6/new_plot_function_hyperbolic_regular_polygon__
comment:5 Changed 6 years ago by
 Branch changed from u/jhonrubia6/new_plot_function_hyperbolic_regular_polygon__ to u/jhonrubia6/new_plot_function_hyperbolic_regular_polygon
comment:6 Changed 6 years ago by
 Branch changed from u/jhonrubia6/new_plot_function_hyperbolic_regular_polygon to t/19856/new_plot_function_hyperbolic_regular_polygon__
comment:7 Changed 6 years ago by
 Branch changed from t/19856/new_plot_function_hyperbolic_regular_polygon__ to t/19856/new_plot_function_hyperbolic_regular_polygon
Changed 6 years ago by
comment:8 Changed 6 years ago by
comment:9 Changed 6 years ago by
 Branch changed from t/19856/new_plot_function_hyperbolic_regular_polygon to u/jhonrubia6/new_plot_function_hyperbolic_regular_polygon
comment:10 Changed 6 years ago by
 Commit set to 1375c98c4d72c92db87c7515d4d1f86aaa5af175
 Status changed from new to needs_review
comment:11 Changed 6 years ago by
 Milestone changed from sage7.0 to sage7.1
comment:12 Changed 6 years ago by
 Branch changed from u/jhonrubia6/new_plot_function_hyperbolic_regular_polygon to public/graphics/plot_hyperbolic_regular_polygon19856
 Commit changed from 1375c98c4d72c92db87c7515d4d1f86aaa5af175 to 7c0416ea44b5bf73b671e36ba2f5b76b9f301fc4
 Reviewers set to Travis Scrimshaw
Looks good overall. I made some reviewer changes. If you agree with them, then please set this to positive review. Thanks.
New commits:
53a4fe0  Merge branch 'u/jhonrubia6/new_plot_function_hyperbolic_regular_polygon' of trac.sagemath.org:sage into public/graphics/plot_hyperbolic_regular_polygon19856

7c0416e  Reviewer changes to hyperbolic regular polygon plotting.

comment:13 Changed 6 years ago by
 Status changed from needs_review to positive_review
Thank you for making the changes. It looks good to me. On behalf of your comment I change the status to positive review
comment:14 Changed 6 years ago by
 Branch changed from public/graphics/plot_hyperbolic_regular_polygon19856 to 7c0416ea44b5bf73b671e36ba2f5b76b9f301fc4
 Resolution set to fixed
 Status changed from positive_review to closed
Note: See
TracTickets for help on using
tickets.
New commits:
Function hiperbolic_regular_polygon created to plot a compact regular hyperbolic polygons given the number of sides, interior angle and optionally an hyperbolic center.