Opened 7 years ago

Closed 7 years ago

#19829 closed defect (fixed)

Cache the results of monoid_generators for IndexedFreeMonoid

Reported by: tscrim Owned by: sage-combinat
Priority: major Milestone: sage-7.0
Component: performance Keywords:
Cc: sage-combinat, nthiery, darij Merged in:
Authors: Travis Scrimshaw Reviewers: Darij Grinberg
Report Upstream: N/A Work issues:
Branch: 0020e67 (Commits, GitHub, GitLab) Commit: 0020e6781706fad7329dfa8755c84fc8e3236f21
Dependencies: Stopgaps:

Status badges

Description

We should cache this because it can be relatively expensive to compute and I have a few tight loops where this becomes a major slowdown.

Change History (5)

comment:1 Changed 7 years ago by tscrim

  • Branch set to public/monoids/cache_indexed_monoid_generators-19829
  • Commit set to 0020e6781706fad7329dfa8755c84fc8e3236f21
  • Status changed from new to needs_review

New commits:

0020e67Cache the monoid (resp. group) generators for the indexed free monoid (resp. group).

comment:2 Changed 7 years ago by tscrim

  • Cc nthiery darij added

comment:3 Changed 7 years ago by darij

  • Status changed from needs_review to positive_review

LGTM (which, at this length, is little surprising :) ).

comment:4 Changed 7 years ago by tscrim

  • Reviewers set to Darij Grinberg

Thanks!

comment:5 Changed 7 years ago by vbraun

  • Branch changed from public/monoids/cache_indexed_monoid_generators-19829 to 0020e6781706fad7329dfa8755c84fc8e3236f21
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.