Opened 3 years ago

Closed 3 years ago

#19746 closed defect (fixed)

Ignore Jupyter notebook default files

Reported by: vbraun Owned by:
Priority: major Milestone: sage-7.0
Component: notebook Keywords:
Cc: Merged in:
Authors: Volker Braun Reviewers: Jeroen Demeyer
Report Upstream: N/A Work issues:
Branch: 4cdb14c (Commits) Commit: 4cdb14c6ef5c95071180e1091b5c8803faf622fe
Dependencies: Stopgaps:

Description


Change History (7)

comment:1 Changed 3 years ago by vbraun

  • Branch set to u/vbraun/ignore_jupyter_notebook_default_files

comment:2 Changed 3 years ago by vbraun

  • Authors set to Volker Braun
  • Commit set to 8b906c0531d471aadd53d13f1e0aaebce5e5190e
  • Component changed from PLEASE CHANGE to notebook
  • Status changed from new to needs_review
  • Type changed from PLEASE CHANGE to defect

New commits:

​8b906c0Ignore Jupyter default files

comment:3 Changed 3 years ago by jdemeyer

I don't agree with Untitled.ipynb: that's just one possible filename of a Jupyter notebook. It only works if you make at most 1 notebook.

comment:4 Changed 3 years ago by git

  • Commit changed from 8b906c0531d471aadd53d13f1e0aaebce5e5190e to 4cdb14c6ef5c95071180e1091b5c8803faf622fe

Branch pushed to git repo; I updated commit sha1. New commits:

​4cdb14cAlso ignore Untitled1.ipynb etc

comment:5 Changed 3 years ago by vbraun

Jupyter auto-saves the notebook under Untitled.ipynb when you create the notebook, you cannot avoid it even if you don't want it. That makes is pretty annoying and prone to accidentally check it in. Are we ever going to intentionally check in Untitled.ipynb? If not then its better to ignore.

comment:6 Changed 3 years ago by jdemeyer

  • Reviewers set to Jeroen Demeyer
  • Status changed from needs_review to positive_review

comment:7 Changed 3 years ago by vbraun

  • Branch changed from u/vbraun/ignore_jupyter_notebook_default_files to 4cdb14c6ef5c95071180e1091b5c8803faf622fe
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.