Opened 7 years ago

Closed 10 months ago

#19680 closed enhancement (invalid)

Add mock, pytest, tox, virtualenv optional packages

Reported by: Jeroen Demeyer Owned by:
Priority: major Milestone: sage-duplicate/invalid/wontfix
Component: packages: optional Keywords:
Cc: Merged in:
Authors: Jeroen Demeyer Reviewers: Michael Orlitzky
Report Upstream: N/A Work issues: Dependencies
Branch: u/jdemeyer/add_mock__pytest__tox_optional_packages (Commits, GitHub, GitLab) Commit: 353210b8d1ebd816028cfbebfae9e00c88306a4e
Dependencies: Stopgaps:

Status badges

Change History (20)

comment:1 Changed 7 years ago by Jeroen Demeyer

Description: modified (diff)
Summary: Add mock, pytest, tox optional packagesAdd mock, py, pytest, tox optional packages

comment:2 Changed 7 years ago by Jeroen Demeyer

Description: modified (diff)

comment:3 Changed 7 years ago by Jeroen Demeyer

Description: modified (diff)

comment:4 Changed 7 years ago by Jeroen Demeyer

Description: modified (diff)
Summary: Add mock, py, pytest, tox optional packagesAdd mock, pytest, tox optional packages + dependencies

comment:5 Changed 7 years ago by Jeroen Demeyer

Description: modified (diff)
Summary: Add mock, pytest, tox optional packages + dependenciesAdd mock, pytest, tox, virtualenv optional packages

comment:6 Changed 7 years ago by Jeroen Demeyer

Description: modified (diff)

comment:7 Changed 7 years ago by Jeroen Demeyer

Description: modified (diff)
Summary: Add mock, pytest, tox, virtualenv optional packagesAdd mock, nose, pytest, tox, virtualenv optional packages

comment:8 Changed 7 years ago by Jeroen Demeyer

Description: modified (diff)
Summary: Add mock, nose, pytest, tox, virtualenv optional packagesAdd mock, pytest, tox, virtualenv optional packages

comment:9 Changed 7 years ago by Jeroen Demeyer

Branch: u/jdemeyer/add_mock__pytest__tox_optional_packages

comment:10 Changed 7 years ago by Jeroen Demeyer

Commit: 353210b8d1ebd816028cfbebfae9e00c88306a4e
Status: newneeds_review

New commits:

353210bAdd mock, pytest, tox, virtualenv optional packages

comment:11 Changed 7 years ago by Volker Braun

Can't these all be installed via pip? Why not make them pip-type packages?

comment:12 in reply to:  11 Changed 7 years ago by Jeroen Demeyer

Replying to vbraun:

Can't these all be installed via pip? Why not make them pip-type packages?

Well, I would like to eventually change the build system to make such packages automatic dependencies if SAGE_CHECK=yes. Many Python packages have a test suite, but we don't run them because they require these extra packages.

Since pip packages bypass the usual local/var/lib/sage/installed system, they should not be used as dependencies of other packages.

comment:13 Changed 7 years ago by Volker Braun

A pip-type package could just update local/var/lib/sage/installed with the output of pip list

IMHO we are going to fight an uphill battle if we keep repackaging more and more of pypi for stuff that has no direct mathematical use. It just wastes our own resources that could be spent elsewhere. We should be relying more on pip, not less.

comment:14 Changed 6 years ago by Jeroen Demeyer

Milestone: sage-6.10sage-7.3
Status: needs_reviewneeds_work
Work issues: Dependencies

needs_work because of the old-style dependency lists. Let me know if anybody wants to review this, then I'll make the required changes.

comment:15 Changed 6 years ago by François Bissey

I'll look, we need those for testing.

comment:16 Changed 6 years ago by Volker Braun

I think its a bit too much to make all testsuite dependencies de facto standard packages because they are dependencies of standard packages.

How about requiring internet access for building with SAGE_CHECK=yes? Then all those pip packages could just be installed by a script-type check_dependencies package that just contains

if SAGE_CHECK
    pip install -r check-requirements.txt

comment:17 in reply to:  16 Changed 3 years ago by Matthias Köppe

Replying to vbraun:

How about requiring internet access for building with SAGE_CHECK=yes? Then all those pip packages could just be installed by a script-type check_dependencies package that just contains

if SAGE_CHECK
    pip install -r check-requirements.txt

I have a version of this in #28998.

comment:18 Changed 2 years ago by Matthias Köppe

Milestone: sage-7.3sage-duplicate/invalid/wontfix
Status: needs_workneeds_review

comment:19 Changed 10 months ago by Michael Orlitzky

Reviewers: Michael Orlitzky
Status: needs_reviewpositive_review

Our python situation is unrecognizable from five years ago; this will need to be started from scratch if there's anything to be salvaged.

comment:20 Changed 10 months ago by Matthias Köppe

Resolution: invalid
Status: positive_reviewclosed
Note: See TracTickets for help on using tickets.