Opened 7 years ago

Closed 10 months ago

## #19680 closed enhancement (invalid)

# Add mock, pytest, tox, virtualenv optional packages

Reported by: | Jeroen Demeyer | Owned by: | |
---|---|---|---|

Priority: | major | Milestone: | sage-duplicate/invalid/wontfix |

Component: | packages: optional | Keywords: | |

Cc: | Merged in: | ||

Authors: | Jeroen Demeyer | Reviewers: | Michael Orlitzky |

Report Upstream: | N/A | Work issues: | Dependencies |

Branch: | u/jdemeyer/add_mock__pytest__tox_optional_packages (Commits, GitHub, GitLab) | Commit: | 353210b8d1ebd816028cfbebfae9e00c88306a4e |

Dependencies: | Stopgaps: |

### Description (last modified by )

These are all packages which are used for testing Python packages.

**Upstream tarballs**:

- https://pypi.python.org/packages/source/m/mock/mock-1.3.0.tar.gz
- https://pypi.python.org/packages/source/n/nose/nose-1.3.7.tar.gz (existing package, just an update)
- https://pypi.python.org/packages/source/p/pbr/pbr-1.8.1.tar.gz
- https://pypi.python.org/packages/source/p/pluggy/pluggy-0.3.1.tar.gz
- https://pypi.python.org/packages/source/p/py/py-1.4.31.tar.gz
- https://pypi.python.org/packages/source/p/pytest/pytest-2.8.4.tar.gz
- https://pypi.python.org/packages/source/t/tox/tox-2.2.1.tar.gz
- https://pypi.python.org/packages/source/v/virtualenv/virtualenv-13.1.2.tar.gz

### Change History (20)

### comment:1 Changed 7 years ago by

Description: | modified (diff) |
---|---|

Summary: | Add mock, pytest, tox optional packages → Add mock, py, pytest, tox optional packages |

### comment:2 Changed 7 years ago by

Description: | modified (diff) |
---|

### comment:3 Changed 7 years ago by

Description: | modified (diff) |
---|

### comment:4 Changed 7 years ago by

Description: | modified (diff) |
---|---|

Summary: | Add mock, py, pytest, tox optional packages → Add mock, pytest, tox optional packages + dependencies |

### comment:5 Changed 7 years ago by

Description: | modified (diff) |
---|---|

Summary: | Add mock, pytest, tox optional packages + dependencies → Add mock, pytest, tox, virtualenv optional packages |

### comment:6 Changed 7 years ago by

Description: | modified (diff) |
---|

### comment:7 Changed 7 years ago by

Description: | modified (diff) |
---|---|

Summary: | Add mock, pytest, tox, virtualenv optional packages → Add mock, nose, pytest, tox, virtualenv optional packages |

### comment:8 Changed 7 years ago by

Description: | modified (diff) |
---|---|

Summary: | Add mock, nose, pytest, tox, virtualenv optional packages → Add mock, pytest, tox, virtualenv optional packages |

### comment:9 Changed 7 years ago by

Branch: | → u/jdemeyer/add_mock__pytest__tox_optional_packages |
---|

### comment:10 Changed 7 years ago by

Commit: | → 353210b8d1ebd816028cfbebfae9e00c88306a4e |
---|---|

Status: | new → needs_review |

### comment:11 follow-up: 12 Changed 7 years ago by

Can't these all be installed via pip? Why not make them pip-type packages?

### comment:12 Changed 7 years ago by

Replying to vbraun:

Can't these all be installed via pip? Why not make them pip-type packages?

Well, I would like to eventually change the build system to make such packages automatic dependencies if `SAGE_CHECK=yes`

. Many Python packages have a test suite, but we don't run them because they require these extra packages.

Since `pip`

packages bypass the usual `local/var/lib/sage/installed`

system, they should not be used as dependencies of other packages.

### comment:13 Changed 7 years ago by

A pip-type package could just update `local/var/lib/sage/installed`

with the output of `pip list`

IMHO we are going to fight an uphill battle if we keep repackaging more and more of pypi for stuff that has no direct mathematical use. It just wastes our own resources that could be spent elsewhere. We should be relying more on pip, not less.

### comment:14 Changed 6 years ago by

Milestone: | sage-6.10 → sage-7.3 |
---|---|

Status: | needs_review → needs_work |

Work issues: | → Dependencies |

needs_work because of the old-style dependency lists. Let me know if anybody wants to review this, then I'll make the required changes.

### comment:16 follow-up: 17 Changed 6 years ago by

I think its a bit too much to make all testsuite dependencies de facto standard packages because they are dependencies of standard packages.

How about requiring internet access for building with SAGE_CHECK=yes? Then all those pip packages could just be installed by a script-type `check_dependencies`

package that just contains

if SAGE_CHECK pip install -r check-requirements.txt

### comment:17 Changed 3 years ago by

### comment:18 Changed 2 years ago by

Milestone: | sage-7.3 → sage-duplicate/invalid/wontfix |
---|---|

Status: | needs_work → needs_review |

### comment:19 Changed 10 months ago by

Reviewers: | → Michael Orlitzky |
---|---|

Status: | needs_review → positive_review |

Our python situation is unrecognizable from five years ago; this will need to be started from scratch if there's anything to be salvaged.

### comment:20 Changed 10 months ago by

Resolution: | → invalid |
---|---|

Status: | positive_review → closed |

**Note:**See TracTickets for help on using tickets.

New commits:

`Add mock, pytest, tox, virtualenv optional packages`