Opened 6 years ago

Closed 6 years ago

#19671 closed defect (fixed)

Ignore all exceptions in ._sage_doc_ attribute access

Reported by: jdemeyer Owned by:
Priority: major Milestone: sage-6.10
Component: documentation Keywords:
Cc: Merged in:
Authors: Jeroen Demeyer Reviewers: François Bissey, Karl-Dieter Crisman
Report Upstream: N/A Work issues:
Branch: c9980ee (Commits, GitHub, GitLab) Commit: c9980ee58ee8c8a5464fd8f5513bfb28d7ae9ed2
Dependencies: Stopgaps:

Status badges

Description (last modified by jdemeyer)

The current docbuilder cannot cope with obj._sage_doc_ accesses raising RuntimeError for example.

Change History (11)

comment:1 Changed 6 years ago by jdemeyer

  • Description modified (diff)
  • Summary changed from FIx docbuild for sagenb upgrade to Ignore all exceptions in ._sage_obj_ attribute access

comment:2 Changed 6 years ago by jdemeyer

  • Branch set to u/jdemeyer/fix_docbuild_for_sagenb_upgrade

comment:3 Changed 6 years ago by git

  • Commit set to c9980ee58ee8c8a5464fd8f5513bfb28d7ae9ed2

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

c9980eeAllow all exceptions in obj._sage_obj_

comment:4 Changed 6 years ago by jdemeyer

  • Description modified (diff)
  • Summary changed from Ignore all exceptions in ._sage_obj_ attribute access to Ignore all exceptions in ._sage_doc_ attribute access

comment:5 Changed 6 years ago by jdemeyer

  • Status changed from new to needs_review

comment:6 follow-up: Changed 6 years ago by kcrisman

Ah, I see now why Sloane.

As I said in #19616, it does build doc successfully with these changes, though I don't have my Sage install convenient to actually try the tests. Anyone else could review that.

comment:7 in reply to: ↑ 6 Changed 6 years ago by jdemeyer

Replying to kcrisman:

try the tests.

You mean doctests or something else? The doctests pass.

comment:8 Changed 6 years ago by kcrisman

I mean doctests, but I didn't know if one was allowed to use the patchbot to confirm this or test it oneself. I usually try them 'by hand' and a few other things, and I won't be able to do more with that until at least Monday, probably Wednesday. If you think this is sufficient though then I certainly trust patchbot + you and you can set it to positive review.

comment:9 Changed 6 years ago by fbissey

  • Reviewers set to François Bissey
  • Status changed from needs_review to positive_review

I think it is sufficient.

comment:10 Changed 6 years ago by kcrisman

  • Reviewers changed from François Bissey to François Bissey, Karl-Dieter Crisman

Thanks François.

comment:11 Changed 6 years ago by vbraun

  • Branch changed from u/jdemeyer/fix_docbuild_for_sagenb_upgrade to c9980ee58ee8c8a5464fd8f5513bfb28d7ae9ed2
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.