Opened 5 years ago
Closed 5 years ago
#19668 closed enhancement (fixed)
Symmetric square L-functions for modular forms
Reported by: | davidloeffler | Owned by: | |
---|---|---|---|
Priority: | major | Milestone: | sage-6.10 |
Component: | modular forms | Keywords: | |
Cc: | mraum | Merged in: | |
Authors: | Martin Raum, David Loeffler | Reviewers: | Marc Masdeu |
Report Upstream: | N/A | Work issues: | |
Branch: | 376cc2f (Commits, GitHub, GitLab) | Commit: | 376cc2f133e40d324341368fbe2ab364decf649f |
Dependencies: | Stopgaps: |
Description
Martin Raum has posted on sage-nt code for computing the symmetric square L-functions of (level 1) modular forms. The goal of this ticket is to get Martin's code into Sage.
Change History (13)
comment:1 Changed 5 years ago by
- Branch set to u/davidloeffler/symmetric_square_l_functions_for_modular_forms
comment:2 Changed 5 years ago by
- Cc mraum added
- Commit set to a498b436bbadc55c4dc897a2738dc599f8bbae52
- Status changed from new to needs_review
comment:3 Changed 5 years ago by
- Status changed from needs_review to needs_work
Oops, I forgot to run long doctests, and one of them is failing on the patchbot.
comment:4 Changed 5 years ago by
- Commit changed from a498b436bbadc55c4dc897a2738dc599f8bbae52 to 0cd82a6fb8af46f0fcd8ae2597465ba248299e55
Branch pushed to git repo; I updated commit sha1. New commits:
0cd82a6 | Trac 19669: fix a broken doctest
|
comment:5 Changed 5 years ago by
That's better. This is now ready for review. (The code should work for certain higher-level forms -- trivial character and squarefree level should be OK -- but that can come in a subsequent ticket; for now it just raises NotImplementedError? if the level isn't 1.)
comment:6 Changed 5 years ago by
- Status changed from needs_work to needs_review
comment:7 Changed 5 years ago by
- Commit changed from 0cd82a6fb8af46f0fcd8ae2597465ba248299e55 to 9ba1341fb37732129e6124daa50b066251b23107
Branch pushed to git repo; I updated commit sha1. New commits:
9ba1341 | Trac 19668: remove deprecated "raise" syntax
|
comment:8 Changed 5 years ago by
One of the patchbot plugins spotted that I had used the old-style, deprecated raise Exception, "message"
syntax rather than raise Exception("message")
, so here's a tiny patch fixing this.
comment:9 Changed 5 years ago by
- Branch changed from u/davidloeffler/symmetric_square_l_functions_for_modular_forms to public/19668-symsquare
comment:10 Changed 5 years ago by
- Commit changed from 9ba1341fb37732129e6124daa50b066251b23107 to 5066faf17dc1a3762bbc841953d866c802b18df1
I noticed that one of the commits had the wrong ticket number in the docstring, so I rewrote the history using "git rebase". The new branch has a single commit, with the correct ticket number; the code is identical to the previously-uploaded branch.
New commits:
5066faf | Trac 19668: Symmetric square L-functions for modular forms
|
comment:11 Changed 5 years ago by
- Commit changed from 5066faf17dc1a3762bbc841953d866c802b18df1 to 376cc2f133e40d324341368fbe2ab364decf649f
Branch pushed to git repo; I updated commit sha1. New commits:
376cc2f | Trac #19668: review patch - removed superfluous whitespace, minor edits.
|
comment:12 Changed 5 years ago by
- Reviewers set to Marc Masdeu
- Status changed from needs_review to positive_review
The implementation looks clean and correct.
I checked that some output was consistent with what is returned from Magma.
It would be worth having a more general implementation (including arbitrary powers, too?). But it's better than nothing, so I'm giving a positive review.
comment:13 Changed 5 years ago by
- Branch changed from public/19668-symsquare to 376cc2f133e40d324341368fbe2ab364decf649f
- Resolution set to fixed
- Status changed from positive_review to closed
New commits:
Trac 19668: Symmetric square L-functions for modular forms