Opened 4 years ago
Closed 4 years ago
#19664 closed defect (fixed)
Fix Laurent series comparison and make it more efficient
Reported by: | jdemeyer | Owned by: | |
---|---|---|---|
Priority: | major | Milestone: | sage-6.10 |
Component: | basic arithmetic | Keywords: | |
Cc: | Merged in: | ||
Authors: | Jeroen Demeyer | Reviewers: | Travis Scrimshaw |
Report Upstream: | N/A | Work issues: | |
Branch: | 519bafb (Commits) | Commit: | 519bafb901ce9304e4fa36be89fd016074dee9f6 |
Dependencies: | Stopgaps: |
Description (last modified by )
This is very bad:
sage: R.<x> = LaurentSeriesRing(ZZ) sage: f = x^-2 + O(x^0); f x^-2 + O(1) sage: g = x^-1 + O(x^0); g x^-1 + O(1) sage: f == g True sage: f-g x^-2 - x^-1 + O(1)
Also this is bad:
sage: R.<x> = LaurentSeriesRing(ZZ) sage: x^(10^10) > 0 ... MemoryError:
Change History (5)
comment:1 Changed 4 years ago by
- Description modified (diff)
- Stopgaps set to #19664
- Summary changed from Make Laurent series comparison more efficient to Fix Laurent series comparison and make it more efficient
comment:2 Changed 4 years ago by
- Branch set to u/jdemeyer/make_laurent_series_comparison_more_efficient
comment:3 Changed 4 years ago by
- Commit set to 519bafb901ce9304e4fa36be89fd016074dee9f6
- Status changed from new to needs_review
comment:4 Changed 4 years ago by
- Reviewers set to Travis Scrimshaw
- Status changed from needs_review to positive_review
- Stopgaps #19664 deleted
LGTM.
comment:5 Changed 4 years ago by
- Branch changed from u/jdemeyer/make_laurent_series_comparison_more_efficient to 519bafb901ce9304e4fa36be89fd016074dee9f6
- Resolution set to fixed
- Status changed from positive_review to closed
Note: See
TracTickets for help on using
tickets.
New commits:
Fix Laurent series comparison and make it more efficient