Opened 4 years ago

Closed 4 years ago

#19663 closed defect (fixed)

Fix sublinking again

Reported by: gouezel Owned by:
Priority: major Milestone: sage-6.10
Component: porting: Cygwin Keywords:
Cc: jdemeyer Merged in:
Authors: Sebastien Gouezel Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: 0437c18 (Commits) Commit: 0437c18aa3260a6fb015b138289113d59514c041
Dependencies: Stopgaps:

Description (last modified by tscrim)

Sublinking in arb. Moreover, fplll links to gmp and mpfr, so the order of libraries in module_list.py should be changed accordingly.

Attachments (1)

pynac-0.5.2.log (36.1 KB) - added by tscrim 4 years ago.

Download all attachments as: .zip

Change History (10)

comment:1 Changed 4 years ago by gouezel

  • Status changed from new to needs_review

comment:2 Changed 4 years ago by tscrim

  • Status changed from needs_review to needs_work

Needs rebasing.

Version 0, edited 4 years ago by tscrim (next)

comment:3 Changed 4 years ago by gouezel

  • Branch changed from u/gouezel/sublinking_20151202 to u/gouezel/sublinking_20151206
  • Commit changed from 757210bb31822285dace7634dd69683272afb18d to 0437c18aa3260a6fb015b138289113d59514c041
  • Dependencies #19627 deleted
  • Status changed from needs_work to needs_review

Rebased on top of 6.10.beta7


New commits:

0437c18 #19663: fix sublinking in arb and libraries order

Changed 4 years ago by tscrim

comment:4 Changed 4 years ago by tscrim

  • Description modified (diff)

LGTM for arb. However, I think there is an issue with Pynac linking to GMP:

.libs/libpynac_la-numeric.o: In function `ZN5GiNaC7numericD2Ev':
/home/Travis/sage/local/var/tmp/sage/build/pynac-0.5.2/src/ginac/numeric.cpp:621:
 undefined reference to `_imp____gmpq_clear'

Full log has been attached.

comment:5 Changed 4 years ago by gouezel

OK, must be new from beta7. I will fix this once I am back in France, in one week.

comment:6 Changed 4 years ago by gouezel

  • Status changed from needs_review to needs_work

comment:7 Changed 4 years ago by jdemeyer

  • Reviewers set to Travis Scrimshaw
  • Status changed from needs_work to positive_review

You can open a new ticket for the pynac build failure.

comment:8 Changed 4 years ago by tscrim

Done at #19678.

comment:9 Changed 4 years ago by vbraun

  • Branch changed from u/gouezel/sublinking_20151206 to 0437c18aa3260a6fb015b138289113d59514c041
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.