Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#19646 closed enhancement (fixed)

Add FLINT declarations for finite fields and p-adics

Reported by: jdemeyer Owned by:
Priority: major Milestone: sage-6.10
Component: interfaces Keywords:
Cc: roed, jpflori, saraedum Merged in:
Authors: Julian Rueth, David Roe, Jean-Pierre Flori, Jeroen Demeyer Reviewers: Jean-Pierre Flori
Report Upstream: N/A Work issues:
Branch: 6cc4151 (Commits) Commit:
Dependencies: Stopgaps:

Description

Add the declarations for #14304 and #16664.

Change History (13)

comment:1 Changed 4 years ago by jdemeyer

  • Branch set to u/jdemeyer/ticket/19646

comment:2 Changed 4 years ago by jdemeyer

  • Commit set to 75bd5ec337f83372e862434d9d1ccb96248fe19a
  • Status changed from new to needs_review

New commits:

75bd5ecAdd FLINT declarations for finite fields and p-adics

comment:3 Changed 4 years ago by jdemeyer

This ticket is mostly just copying stuff from #14304 and #16664. I did add a few more changes, so somebody should still look at the branch.

comment:4 follow-up: Changed 4 years ago by jpflori

Thanks for splitting this out of the other tickets. A note on the fq bindings, could you add the fq_div functions? They were mysteriously left out of the release when I started #16664, but should be in now.

comment:5 in reply to: ↑ 4 Changed 4 years ago by jdemeyer

Replying to jpflori:

Thanks for splitting this out of the other tickets. A note on the fq bindings, could you add the fq_div functions? They were mysteriously left out of the release when I started #16664, but should be in now.

I saw them commented out, so I didn't know what to do with them.

Note that there was no need to comment them out in the first place: it's not a problem to declare functions which don't actually exist. You will get a compiler error when you use them, but not if you just declare them.

comment:6 Changed 4 years ago by jdemeyer

There is still no fq_nmod_div...

comment:7 Changed 4 years ago by git

  • Commit changed from 75bd5ec337f83372e862434d9d1ccb96248fe19a to 2fa86008c6c1699a3f2be2000784781926367edc

Branch pushed to git repo; I updated commit sha1. New commits:

2fa8600Add fq_div()

comment:8 Changed 4 years ago by jpflori

Yes indeed... And I see

FLINT_DLL void fq_div(fq_t rop, const fq_t op1, const fq_t op2, const fq_ctx_t ctx);
FLINT_DLL void fq_sqr(fq_t rop, const fq_t op, const fq_ctx_t ctx);
FLINT_DLL void fq_div(fq_t rop, const fq_t op1, const fq_t op2, const fq_ctx_t ctx);
FLINT_DLL void fq_sqr(fq_t rop, const fq_t op, const fq_ctx_t ctx);

in the trunk version of fq.h. I'll make a pull request upstream.

comment:9 Changed 4 years ago by git

  • Commit changed from 2fa86008c6c1699a3f2be2000784781926367edc to 6cc4151dd30a3f7bb75e801f12f8a920d0c95356

Branch pushed to git repo; I updated commit sha1. New commits:

6cc4151Use standard copyright template

comment:10 Changed 4 years ago by jpflori

  • Reviewers set to Jean-Pierre Flori
  • Status changed from needs_review to positive_review

comment:11 Changed 4 years ago by jdemeyer

Thanks!

comment:12 Changed 4 years ago by vbraun

  • Branch changed from u/jdemeyer/ticket/19646 to 6cc4151dd30a3f7bb75e801f12f8a920d0c95356
  • Resolution set to fixed
  • Status changed from positive_review to closed

comment:13 Changed 4 years ago by jpflori

  • Commit 6cc4151dd30a3f7bb75e801f12f8a920d0c95356 deleted

Actually there is a fq_nmod_div prototype which gets defined through the inclusion of fq_templates.h.

Note: See TracTickets for help on using tickets.