Opened 4 years ago

Closed 4 years ago

Last modified 17 months ago

#19633 closed enhancement (fixed)

Optimize lazy imports

Reported by: jdemeyer Owned by:
Priority: minor Milestone: sage-6.10
Component: misc Keywords:
Cc: Merged in:
Authors: Jeroen Demeyer Reviewers: Travis Scrimshaw
Report Upstream: Fixed upstream, but not in a stable release. Work issues:
Branch: 308fa02 (Commits) Commit:
Dependencies: Stopgaps:

Description (last modified by jdemeyer)

  1. make _get_object() a cpdef method again, like it was with Cython 0.18 and before, see #14452. This exposes a Python bug (incorrectly claimed to be a Cython bug) which needs to be fixed.
  1. use PyObject_RichCompare() as a shortcut in __richcmp__().
  1. use print syntax compatible with Python 3.

Upstream bug: http://bugs.python.org/issue25750

Change History (16)

comment:1 Changed 4 years ago by jdemeyer

  • Description modified (diff)
  • Report Upstream changed from N/A to Reported upstream. No feedback yet.
  • Summary changed from Small fixes to lazy imports to Optimize lazy imports

comment:2 Changed 4 years ago by jdemeyer

  • Description modified (diff)

comment:3 Changed 4 years ago by jdemeyer

  • Dependencies set to #18542
  • Description modified (diff)

comment:4 Changed 4 years ago by jdemeyer

  • Description modified (diff)

comment:5 Changed 4 years ago by jdemeyer

  • Description modified (diff)

comment:6 Changed 4 years ago by jdemeyer

  • Description modified (diff)

comment:7 Changed 4 years ago by jdemeyer

  • Branch set to u/jdemeyer/ticket/19633

comment:8 Changed 4 years ago by jdemeyer

  • Commit set to 901175d1d4c112fa4f3c6f1aadfbe6fa4fd46d34
  • Status changed from new to needs_review

New commits:

51ce428Add a sage --package update command
342efadUpdate to Python 2.7.10
901175dOptimize lazy import

comment:9 Changed 4 years ago by git

  • Commit changed from 901175d1d4c112fa4f3c6f1aadfbe6fa4fd46d34 to bbd9edab2be23d70b18c44a96badd24bfca28978

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

bbd9edaOptimize lazy import

comment:10 Changed 4 years ago by jdemeyer

  • Dependencies #18542 deleted

comment:11 Changed 4 years ago by tscrim

  • Reviewers set to Travis Scrimshaw

Nearly trivial, but from my interpretation of the 3rd party packaging doc, we were suppose to have the first patched version be .p0? If we are suppose to be .p1, then you can set a positive review. Otherwise, you can set positive review after the appropriate change.

comment:12 Changed 4 years ago by jdemeyer

I really don't think it matters if it's .p0 or .p1. But I'll change it because you ask.

comment:13 Changed 4 years ago by git

  • Commit changed from bbd9edab2be23d70b18c44a96badd24bfca28978 to 308fa0258773ac7a9b3d797aab268febaa09846e

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

308fa02Optimize lazy import

comment:14 Changed 4 years ago by jdemeyer

  • Report Upstream changed from Reported upstream. No feedback yet. to Reported upstream. Developers acknowledge bug.
  • Status changed from needs_review to positive_review

comment:15 Changed 4 years ago by vbraun

  • Branch changed from u/jdemeyer/ticket/19633 to 308fa0258773ac7a9b3d797aab268febaa09846e
  • Resolution set to fixed
  • Status changed from positive_review to closed

comment:16 Changed 17 months ago by jdemeyer

  • Commit 308fa0258773ac7a9b3d797aab268febaa09846e deleted
  • Report Upstream changed from Reported upstream. Developers acknowledge bug. to Fixed upstream, but not in a stable release.

Finally...

Note: See TracTickets for help on using tickets.