Opened 5 years ago

Closed 5 years ago

#19563 closed enhancement (fixed)

Upgrade arb and fix FLINT includes

Reported by: jdemeyer Owned by:
Priority: major Milestone: sage-6.10
Component: packages: standard Keywords:
Cc: fbissey Merged in:
Authors: Jeroen Demeyer Reviewers: Volker Braun
Report Upstream: Reported upstream. Developers acknowledge bug. Work issues:
Branch: d6c3c85 (Commits) Commit: d6c3c85dc75803c3e6676c8700e648db53343ed0
Dependencies: #19152 Stopgaps:

Description (last modified by jdemeyer)

Upstream: http://sage.ugent.be/www/jdemeyer/sage/arb-2.7.0.tar.bz2 (packaged from git repo since upstream doesn't seem to provide tarballs)

Pull request: https://github.com/fredrik-johansson/arb/pull/55

Change History (21)

comment:1 Changed 5 years ago by fbissey

  • Cc fbissey added

comment:2 Changed 5 years ago by fbissey

One doctest failure after straight upgrading arb (linux 64bit).

sage -t --long usr/lib/python2.7/site-packages/sage/rings/real_arb.pyx
**********************************************************************
File "usr/lib/python2.7/site-packages/sage/rings/real_arb.pyx", line 2620, in sage.rings.real_arb.RealBall.log_gamma
Failed example:
    RBF(1/2).log_gamma()
Expected:
    [0.572364942924700 +/- 4.87e-16]
Got:
    [0.572364942924700 +/- 2.67e-16]
**********************************************************************
1 item had failures:
   1 of   3 in sage.rings.real_arb.RealBall.log_gamma
    [494 tests, 1 failure, 0.30 s]
----------------------------------------------------------------------
sage -t --long usr/lib/python2.7/site-packages/sage/rings/real_arb.pyx  # 1 doctest failed
----------------------------------------------------------------------
Total time for all tests: 0.5 seconds
    cpu time: 0.3 seconds
    cumulative wall time: 0.3 seconds
Last edited 5 years ago by fbissey (previous) (diff)

comment:3 Changed 5 years ago by jdemeyer

  • Description modified (diff)

comment:4 follow-up: Changed 5 years ago by fbissey

Oh there is a tarball at https://github.com/fredrik-johansson/arb/archive/2.7.0.tar.gz but of course as a lot of those coming from github it has to be renamed.

comment:5 in reply to: ↑ 4 Changed 5 years ago by jdemeyer

Replying to fbissey:

Oh there is a tarball at https://github.com/fredrik-johansson/arb/archive/2.7.0.tar.gz

Right, this is what I meant with "packaged from git repo".

comment:6 Changed 5 years ago by jdemeyer

  • Branch set to u/jdemeyer/upgrade_arb_and_fix_flint_includes

comment:7 Changed 5 years ago by jdemeyer

  • Commit set to c4fe46cf005f6e39dae1e345672a89edefd1913a
  • Report Upstream changed from N/A to Not yet reported upstream; Will do shortly.

Last 10 new commits:

ab117dacomplex_ball: abort() --> sig_error()
1ee8c16ref manual: rm reference to arb being optional
865e6d5{real,complex}_arb: more doc on precision issues
d289538{real,complex}_arb: move SEEALSO blocks after EXAMPLES
fe1b071RealBall: clarify doc of upper(), lower(), endpoints()
a38574acomplex_arb is no longer experimental
d5af324{real,complex}_arb: minor doc fixes
f43e94aRealBall: minor change to __hash__
7e6b5d0real_arb: minor doc fix
c4fe46cUpgrade to arb 2.7.0 and fix flint includes

comment:8 Changed 5 years ago by jdemeyer

  • Dependencies set to #19152

comment:9 Changed 5 years ago by git

  • Commit changed from c4fe46cf005f6e39dae1e345672a89edefd1913a to ac6e2c3d68003dad73e453c5bdf908179a44d389

Branch pushed to git repo; I updated commit sha1. New commits:

ac6e2c3Fix arb doctest failure in log_gamma()

comment:10 Changed 5 years ago by jdemeyer

  • Description modified (diff)
  • Report Upstream changed from Not yet reported upstream; Will do shortly. to Reported upstream. No feedback yet.
  • Status changed from new to needs_review

comment:11 Changed 5 years ago by jdemeyer

  • Report Upstream changed from Reported upstream. No feedback yet. to Reported upstream. Developers acknowledge bug.

comment:12 Changed 5 years ago by vbraun

  • Reviewers set to Volker Braun
  • Status changed from needs_review to positive_review

comment:13 follow-ups: Changed 5 years ago by fbissey

  • Status changed from positive_review to needs_work

I am surprised making arb a standard package didn't cause any issue on OS X 10.11. The library lack an install_name which has been the sources of trouble just building there. A small fix just like in cliquer's spkg-install would do the trick

if [ "$UNAME" = "Darwin" ]; then
    install_name_tool -id "${SAGE_LOCAL}"/lib/libarb.dylib "${SAGE_LOCAL}"/lib/libarb.dylib
fi

comment:14 in reply to: ↑ 13 ; follow-up: Changed 5 years ago by jdemeyer

Replying to fbissey:

I am surprised making arb a standard package didn't cause any issue on OS X 10.11. The library lack an install_name which has been the sources of trouble just building there.

Is this problem related to the upgrade of arb?

comment:15 in reply to: ↑ 14 Changed 5 years ago by fbissey

Replying to jdemeyer:

Replying to fbissey:

I am surprised making arb a standard package didn't cause any issue on OS X 10.11. The library lack an install_name which has been the sources of trouble just building there.

Is this problem related to the upgrade of arb?

Arguably it should have been dealt with in #18546 or earlier.

comment:16 in reply to: ↑ 13 Changed 5 years ago by jdemeyer

  • Status changed from needs_work to positive_review

Replying to fbissey:

I am surprised making arb a standard package didn't cause any issue on OS X 10.11. The library lack an install_name which has been the sources of trouble just building there. A small fix just like in cliquer's spkg-install would do the trick

if [ "$UNAME" = "Darwin" ]; then
    install_name_tool -id "${SAGE_LOCAL}"/lib/libarb.dylib "${SAGE_LOCAL}"/lib/libarb.dylib
fi

This is now #19627.

comment:17 Changed 5 years ago by vbraun

The arb testsuite dies with

$ SAGE_CHECK=yes ./sage -p arb
...
Successfully installed arb-2.7.0.p0
Running the test suite for arb-2.7.0.p0...
make[1]: warning: -jN forced in submake: disabling jobserver mode.
make[1]: Entering directory '/mnt/disk/home/release/Sage/local/var/tmp/sage/build/arb-2.7.0.p0/src'
make[1]: Nothing to be done for 'shared'.
make[1]: Leaving directory '/mnt/disk/home/release/Sage/local/var/tmp/sage/build/arb-2.7.0.p0/src'
make[1]: warning: -jN forced in submake: disabling jobserver mode.
make[1]: Entering directory '/mnt/disk/home/release/Sage/local/var/tmp/sage/build/arb-2.7.0.p0/src'
make[1]: Nothing to be done for 'static'.
make[1]: Leaving directory '/mnt/disk/home/release/Sage/local/var/tmp/sage/build/arb-2.7.0.p0/src'
make[1]: warning: -jN forced in submake: disabling jobserver mode.
make[1]: Entering directory '/mnt/disk/home/release/Sage/local/var/tmp/sage/build/arb-2.7.0.p0/src'
make[2]: Entering directory '/mnt/disk/home/release/Sage/local/var/tmp/sage/build/arb-2.7.0.p0/src'
make[2]: warning: -jN forced in submake: disabling jobserver mode.
make[2]: Nothing to be done for 'shared'.
make[2]: Leaving directory '/mnt/disk/home/release/Sage/local/var/tmp/sage/build/arb-2.7.0.p0/src'
make[2]: Entering directory '/mnt/disk/home/release/Sage/local/var/tmp/sage/build/arb-2.7.0.p0/src'
make[2]: warning: -jN forced in submake: disabling jobserver mode.
make[2]: Nothing to be done for 'static'.
make[2]: Leaving directory '/mnt/disk/home/release/Sage/local/var/tmp/sage/build/arb-2.7.0.p0/src'
make[1]: Leaving directory '/mnt/disk/home/release/Sage/local/var/tmp/sage/build/arb-2.7.0.p0/src'
make[1]: warning: -jN forced in submake: disabling jobserver mode.
make[1]: Entering directory '/mnt/disk/home/release/Sage/local/var/tmp/sage/build/arb-2.7.0.p0/src/fmpr'
    CC   ../build/fmpr/test/t-add
    CC   ../build/fmpr/test/t-set_fmpq
    CC   ../build/fmpr/test/t-root
    CC   ../build/fmpr/test/t-mul
    CC   ../build/fmpr/test/t-sub
    CC   ../build/fmpr/test/t-exp
    CC   ../build/fmpr/test/t-abs_bound_lt_2exp_si
    CC   ../build/fmpr/test/t-mul_si
    CC   ../build/fmpr/test/t-set_round_ui_2exp_fmpz
    CC   ../build/fmpr/test/t-get_d
test/t-mul_si.c:27:25: fatal error: long_extras.h: No such file or directory
compilation terminated.
../Makefile.subdirs:78: recipe for target '../build/fmpr/test/t-mul_si' failed
make[1]: *** [../build/fmpr/test/t-mul_si] Error 1
make[1]: *** Waiting for unfinished jobs....
make[1]: Leaving directory '/mnt/disk/home/release/Sage/local/var/tmp/sage/build/arb-2.7.0.p0/src/fmpr'
Makefile:169: recipe for target 'check' failed
make: *** [check] Error 2

Thoughts?

comment:18 Changed 5 years ago by jdemeyer

  • Status changed from positive_review to needs_work

comment:19 Changed 5 years ago by git

  • Commit changed from ac6e2c3d68003dad73e453c5bdf908179a44d389 to d6c3c85dc75803c3e6676c8700e648db53343ed0

Branch pushed to git repo; I updated commit sha1. New commits:

d6c3c85Fix more includes

comment:20 Changed 5 years ago by jdemeyer

  • Status changed from needs_work to positive_review

I forgot to change some includes. With this patch, the testsuite passes. Since I'm just adding a few changes in the spirit of the old branch, I assume the positive review still stands.

comment:21 Changed 5 years ago by vbraun

  • Branch changed from u/jdemeyer/upgrade_arb_and_fix_flint_includes to d6c3c85dc75803c3e6676c8700e648db53343ed0
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.