Opened 5 years ago

Closed 18 months ago

Last modified 18 months ago

#19554 closed defect (fixed)

Workaround for #19553 for FiniteEnumeratedSet

Reported by: tscrim Owned by: tscrim
Priority: major Milestone: sage-8.8
Component: combinatorics Keywords:
Cc: sage-combinat Merged in:
Authors: Travis Scrimshaw Reviewers: Daniel Krenn
Report Upstream: N/A Work issues:
Branch: 1e3ace7 (Commits) Commit:
Dependencies: Stopgaps:

Description (last modified by tscrim)

We work around #19553 by trying directly to see if _element_constructor_ works if Parent.__call__ fails with a TypeError.

Change History (8)

comment:1 Changed 5 years ago by tscrim

  • Branch set to public/sets/workaround_FiniteEnumeratedSet-19554
  • Commit set to 3e7eaddafebea45d5a62454bba6e34f068b8febc
  • Status changed from new to needs_review

New commits:

3e7eaddA workaround for #19554.

comment:2 Changed 4 years ago by cheuberg

  • Status changed from needs_review to needs_work

doctest fails (cf. patchbot).

comment:3 Changed 3 years ago by git

  • Commit changed from 3e7eaddafebea45d5a62454bba6e34f068b8febc to 1f3c136ccf10c4bfa214c2fe466616e35d644c27

Branch pushed to git repo; I updated commit sha1. New commits:

6afcb52Merge branch 'public/sets/workaround_FiniteEnumeratedSet-19554' of git://trac.sagemath.org/sage into public/sets/workaround_FiniteEnumeratedSet-19554
1f1ace2Try Parent.__call__ first and if that fails, try once more _element_constructor_.
1f3c136Try first Parent.__call__ then fallback on self._element_constructor_.

comment:4 Changed 3 years ago by git

  • Commit changed from 1f3c136ccf10c4bfa214c2fe466616e35d644c27 to 1e3ace7e6f2b004dccb83e6f726d7bc12eda8279

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

06b4b10A workaround for #19554.
1e3ace7Try Parent.__call__ first and if that fails, try once more _element_constructor_.

comment:5 Changed 3 years ago by tscrim

  • Description modified (diff)
  • Milestone changed from sage-6.10 to sage-8.1
  • Status changed from needs_work to needs_review

comment:6 Changed 18 months ago by dkrenn

  • Reviewers set to Daniel Krenn
  • Status changed from needs_review to positive_review

LGTM

comment:7 Changed 18 months ago by vbraun

  • Branch changed from public/sets/workaround_FiniteEnumeratedSet-19554 to 1e3ace7e6f2b004dccb83e6f726d7bc12eda8279
  • Resolution set to fixed
  • Status changed from positive_review to closed

comment:8 Changed 18 months ago by slelievre

  • Commit 1e3ace7e6f2b004dccb83e6f726d7bc12eda8279 deleted
  • Milestone changed from sage-8.1 to sage-8.8
Note: See TracTickets for help on using tickets.