Opened 5 years ago
Last modified 5 years ago
#19532 closed enhancement
asymptotic expansion generators related to singularity analysis — at Version 11
Reported by:  dkrenn  Owned by:  

Priority:  major  Milestone:  sage7.1 
Component:  asymptotic expansions  Keywords:  
Cc:  behackl, cheuberg  Merged in:  
Authors:  Daniel Krenn  Reviewers:  Clemens Heuberger 
Report Upstream:  N/A  Work issues:  
Branch:  u/cheuberg/asy/singularityanalysis (Commits)  Commit:  a3a6dfd1d57038d14ee453d37884da19ad6d59cd 
Dependencies:  #19437, #19510, #19576  Stopgaps: 
Description (last modified by )
Create asymptotic expansions coming from pole singularities.
Change History (11)
comment:1 Changed 5 years ago by
 Branch set to u/dkrenn/asy/singularityanalysis
comment:2 Changed 5 years ago by
 Commit set to 3214c83c3a91f0eea73ad0068473661b1c228bfc
comment:3 Changed 5 years ago by
 Commit changed from 3214c83c3a91f0eea73ad0068473661b1c228bfc to 8ec2dfd1c61a30960d80cba160d46a93014cdad5
Branch pushed to git repo; I updated commit sha1. New commits:
8ec2dfd  fix docstring

comment:4 Changed 5 years ago by
 Branch changed from u/dkrenn/asy/singularityanalysis to u/cheuberg/asy/singularityanalysis
comment:5 Changed 5 years ago by
 Commit changed from 8ec2dfd1c61a30960d80cba160d46a93014cdad5 to ab1cd26496a64408e8701bfe306ee6ee399e2d76
comment:6 Changed 5 years ago by
 Commit changed from ab1cd26496a64408e8701bfe306ee6ee399e2d76 to 9796508e6aac3883a8175a19294456685ba37c64
Branch pushed to git repo; I updated commit sha1. New commits:
9796508  Trac #19532: fix doctest

comment:7 Changed 5 years ago by
 Milestone changed from sage6.10 to sage7.1
My impression is that you implemented poles and still want to implement logarithmic singularities in the same ticket. I'd suggest to restrict this ticket to poles (and raising NotImplementedError
for the logarithmic singularities, as apparently done in the current code) and to leave extensions to future tickets.
comment:8 Changed 5 years ago by
 Dependencies changed from #19437, #19510 to #19437, #19510, #19576
comment:9 Changed 5 years ago by
 Status changed from new to needs_review
comment:10 Changed 5 years ago by
 Commit changed from 9796508e6aac3883a8175a19294456685ba37c64 to a3a6dfd1d57038d14ee453d37884da19ad6d59cd
Branch pushed to git repo; I updated commit sha1. New commits:
f114f9e  Trac #19532: Add to table of contents

ede5173  Trac #19532: Minor documentation fixes

267718d  Trac #19532: Additional tests

0860173  Trac #19532: List log log factors, document missing implementations

a3a6dfd  Trac #19532: Add references

comment:11 Changed 5 years ago by
 Description modified (diff)
 Reviewers set to Clemens Heuberger
 Status changed from needs_review to needs_info
I reviewed the code, doctests pass, documentation and code are mostly fine. I added a few reviewer commits, please crossreview.
There is only the question on what to do with integral alpha <= 0
. Currently, the result is 0
which is certainly correct for sufficiently large values of the parameter. However, the rest of the asymptotics code as I remember it does not really assume "sufficiently large values of the parameter".
I am not really sure which result is appropriate. Several options:
0
 valid for sufficiently large values of the parameter. (current version)O(1)
 correct, but bad for applications. raise an error
 add a warning to the documentation
 add a note to the documentation
Implemented pole singularities.
Last 10 new commits:
simplify coefficients automatically and use the faster algorithm per default
docu
result over QQ if skipparameter given
toc entry (at top of file)
SR.symbol: set parent correctly (inheritance)
Move pynac_symbol_registry to cdef attribute SR.symbols
Merge branch 'u/jdemeyer/symbolic/subvar' of trac.sagemath.org:sage into asy/singularityanalysis
calculate coefficients of singularity analysis (pole type)
generator SingularityAnalysis (pole type)
explicitly specify a default defaultprecision