Opened 4 years ago

Closed 4 years ago

#19528 closed enhancement (fixed)

map_coefficients for asymptotic expansions

Reported by: dkrenn Owned by:
Priority: major Milestone: sage-7.1
Component: asymptotic expansions Keywords:
Cc: behackl Merged in:
Authors: Daniel Krenn Reviewers: Clemens Heuberger
Report Upstream: N/A Work issues:
Branch: d62912f (Commits) Commit: d62912fb869c22e5706849c960614e7adee6f39e
Dependencies: Stopgaps:

Description

Write a method which transforms asymptotic expansions by applying a function on its coefficients.

Change History (9)

comment:1 Changed 4 years ago by dkrenn

  • Branch set to u/dkrenn/asy/map_coefficients

comment:2 Changed 4 years ago by dkrenn

  • Commit set to bdcb72be9df4b2e57a94be7d250e78e8b5105304
  • Status changed from new to needs_review

New commits:

421e377mutable poset map: remove elements ``None``
1d28240term monoid: write change_parameter
2c37889correct a bug in change_parameter
bdcb72bwrite map_coefficients

comment:3 Changed 4 years ago by cheuberg

  • Branch changed from u/dkrenn/asy/map_coefficients to u/cheuberg/asy/map_coefficients

comment:4 Changed 4 years ago by cheuberg

  • Cc behackl added
  • Commit changed from bdcb72be9df4b2e57a94be7d250e78e8b5105304 to 8a71ba386f8c1dfb89a27e0f0f068f6771aaa740
  • Reviewers set to Clemens Heuberger
  • Status changed from needs_review to needs_work

One reviewer commit and to minor issues:

  1. TermMonoidFactory. When reading its documentation because it was used by change_parameter, I am no longer happy with the description (and probably also the name) of the parameter term: "or an existing instance of a term." should be replaced by "or an existing instance of a term monoid". Also "the kind of term that shall be created" is not really precise ("the kind of terms held in the new term monoid")
  2. map_coefficients: == 0 vs. is_zero()?

New commits:

8a71ba3Trac #19528: simplification of documentation

comment:5 Changed 4 years ago by cheuberg

  • Milestone changed from sage-6.10 to sage-7.1

The build error by the patchbot Athena seems to be unrelated to this ticket.

comment:6 Changed 4 years ago by dkrenn

  • Branch changed from u/cheuberg/asy/map_coefficients to u/dkrenn/asy/map_coefficients

comment:7 Changed 4 years ago by dkrenn

  • Commit changed from 8a71ba386f8c1dfb89a27e0f0f068f6771aaa740 to d62912fb869c22e5706849c960614e7adee6f39e
  • Status changed from needs_work to needs_review

New commits:

dc9d496Trac #19528: rename term to term_monoid and improve doc
d62912fTrac #19528: change "== 0" to ".is_zero()"

comment:8 Changed 4 years ago by cheuberg

  • Status changed from needs_review to positive_review

LGTM.

comment:9 Changed 4 years ago by vbraun

  • Branch changed from u/dkrenn/asy/map_coefficients to d62912fb869c22e5706849c960614e7adee6f39e
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.