Opened 5 years ago

Closed 5 years ago

#19527 closed enhancement (fixed)

Clean up GLPK interface

Reported by: jdemeyer Owned by:
Priority: major Milestone: sage-6.10
Component: cython Keywords:
Cc: mkoeppe, yzh, zwang Merged in:
Authors: Jeroen Demeyer Reviewers: Dima Pasechnik
Report Upstream: N/A Work issues:
Branch: 063c178 (Commits) Commit: 063c178101adc04e6f02c7c450abf075ecbd57d5
Dependencies: #19472 Stopgaps:

Description


Change History (17)

comment:1 Changed 5 years ago by jdemeyer

  • Branch set to u/jdemeyer/ticket/19527

comment:2 Changed 5 years ago by jdemeyer

  • Commit set to 5112e5cb4190a482f69bed1b7aca1d3dc09ad9ec
  • Status changed from new to needs_review

New commits:

​5112e5cClean up GLPK interface

comment:3 Changed 5 years ago by git

  • Commit changed from 5112e5cb4190a482f69bed1b7aca1d3dc09ad9ec to 1106593e6b55a5374209b42c5f8a3d1cc6bba2cb

Branch pushed to git repo; I updated commit sha1. New commits:

​1106593Add MBD and ENV, fix indentation

comment:4 Changed 5 years ago by jdemeyer

  • Status changed from needs_review to needs_work

comment:5 Changed 5 years ago by git

  • Commit changed from 1106593e6b55a5374209b42c5f8a3d1cc6bba2cb to 1b18116a2bdfa9af96ed72ddbd954d6696075968

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

​1b18116Clean up GLPK interface

comment:6 Changed 5 years ago by jdemeyer

  • Status changed from needs_work to needs_review

comment:7 Changed 5 years ago by git

  • Commit changed from 1b18116a2bdfa9af96ed72ddbd954d6696075968 to 59db12bb2e55091b3c229d907993db6a6a39fe0b

Branch pushed to git repo; I updated commit sha1. New commits:

​59db12bAdd glp_init_env() and glp_free_env()

comment:8 Changed 5 years ago by dimpase

there is a merge conflict with #19472.

comment:9 Changed 5 years ago by dimpase

  • Cc mkoeppe added

comment:10 Changed 5 years ago by jdemeyer

  • Dependencies set to #19472
  • Status changed from needs_review to needs_work

Should be easy to fix.

comment:11 Changed 5 years ago by git

  • Commit changed from 59db12bb2e55091b3c229d907993db6a6a39fe0b to 063c178101adc04e6f02c7c450abf075ecbd57d5

Branch pushed to git repo; I updated commit sha1. New commits:

​37e90e8More basis status and tableau data functions
​f2f5df3Merge tag '6.10.beta4' into t/19472/GLPK_backend_More_basis_status_and_tableau_data_functions
​3c43a2eUndo GLPK interface changes
​b7fa1f9Merge branch 't/19472/GLPK_backend_More_basis_status_and_tableau_data_functions' into t/19527/ticket/19527
​e7856e9Redo GLPK interface changes from #19472
​063c178Indent by 4 spaces

comment:12 Changed 5 years ago by jdemeyer

  • Status changed from needs_work to needs_review

comment:13 Changed 5 years ago by dimpase

  • Status changed from needs_review to positive_review

looks good to me. I hope Matthias (mkoeppe) can work with this just fine.

comment:14 Changed 5 years ago by mkoeppe

  • Cc yzh zwang added

comment:15 Changed 5 years ago by jdemeyer

  • Reviewers set to ​Dima Pasechnik

comment:16 Changed 5 years ago by vbraun

  • Reviewers changed from ​Dima Pasechnik to Dima Pasechnik

Invisible space...

comment:17 Changed 5 years ago by vbraun

  • Branch changed from u/jdemeyer/ticket/19527 to 063c178101adc04e6f02c7c450abf075ecbd57d5
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.