Opened 6 years ago

Last modified 2 years ago

#19493 new task

convert the ore_algebra from a package to a part of sage

Reported by: chapoton Owned by:
Priority: major Milestone: sage-6.10
Component: algebra Keywords: ore_algebra
Cc: mkauers, mmezzarobba Merged in:
Authors: Reviewers:
Report Upstream: N/A Work issues:
Branch: public/19493 (Commits, GitHub, GitLab) Commit: fcc2f59a036d04632ae17f592d8604c0e8145287
Dependencies: Stopgaps:

Status badges

Description (last modified by chapoton)

This ticket aims at integrating fully the code of the package ore_algebra in sage.

http://www.risc.jku.at/research/combinat/software/ore_algebra/

Change History (12)

comment:1 Changed 6 years ago by chapoton

  • Description modified (diff)

comment:2 Changed 6 years ago by jdemeyer

I think you need to justify why you want to do this.

comment:3 Changed 6 years ago by jdemeyer

If you do this, the code should satisfy the Sage standard of code. In particular, it should be fully doctested (which is far from the case for the current ore_algebra package).

comment:4 Changed 6 years ago by chapoton

Yes, indeed. The reason I would like to do this is because this code is useful, and including it will prevent us to break this by our numerous and rapid changes and deprecations.

For the documentation, of course, it will have to meet the requirements.

Last edited 2 years ago by slelievre (previous) (diff)

comment:5 Changed 6 years ago by jhpalmieri

This conversion was also suggested at #19175.

comment:6 Changed 6 years ago by chapoton

  • Branch set to public/19493
  • Commit set to 8daae04dd4683df8472b97dbdf1efe1e87255e4a

I made a branch, starting from the package version 0.2, but did not change the imports, so this is probably not working yet.

And this is seriously lacking docs.


New commits:

8daae04trac #19493 initial inclusion of the Ore algebras (NEEDS DOC)

comment:7 Changed 6 years ago by git

  • Commit changed from 8daae04dd4683df8472b97dbdf1efe1e87255e4a to b974749efa7d3dfd0239e8ad2b137a8dc98c5ca2

Branch pushed to git repo; I updated commit sha1. New commits:

b974749trac #19493 change one import, put some raise into py3, whitespace cleanup

comment:8 Changed 5 years ago by git

  • Commit changed from b974749efa7d3dfd0239e8ad2b137a8dc98c5ca2 to c5e4ed62feaa9123c7b100f1f0428cf201cbb8af

Branch pushed to git repo; I updated commit sha1. New commits:

c5e4ed6Merge branch 'public/19493' in 7.4.b6

comment:9 Changed 5 years ago by git

  • Commit changed from c5e4ed62feaa9123c7b100f1f0428cf201cbb8af to fcc2f59a036d04632ae17f592d8604c0e8145287

Branch pushed to git repo; I updated commit sha1. New commits:

fcc2f59turning raise to py3 syntax

comment:10 Changed 5 years ago by tmonteil

  • Cc mkauers mmezzarobba added

Note that ore_algebra is still evolving, see new version at #22870. So if we want a merge to happen (do we?), i guess it should be made in collaboration with upstream developpers. Meanwhile, perhaps should the proposed modifications directly be contributed upstream.

comment:11 Changed 2 years ago by chapoton

  • Keywords ore_algebra added

comment:12 Changed 2 years ago by jhpalmieri

See also #26332. Upstream is still developing their code, so we should either drop this ticket or invite them to make ore_algebra part of the Sage library.

Note: See TracTickets for help on using tickets.