Opened 3 years ago
Closed 3 years ago
#19484 closed enhancement (fixed)
sage unzip
Reported by:  ncohen  Owned by:  

Priority:  major  Milestone:  sage6.10 
Component:  distribution  Keywords:  
Cc:  Merged in:  
Authors:  Nathann Cohen  Reviewers:  Volker Braun 
Report Upstream:  N/A  Work issues:  
Branch:  727ac93 (Commits)  Commit:  727ac938b282c541f489d273c2a3cf7bbc96fc2e 
Dependencies:  Stopgaps: 
Description
As discussed on sagedevel [1], we lack a way to unzip files.
This very short python script does the job.
Nathann
[1] https://groups.google.com/d/topic/sagedevel/1uoTUsQ29Sw/discussion
Change History (15)
comment:1 Changed 3 years ago by
 Branch set to public/19484
 Status changed from new to needs_review
comment:2 Changed 3 years ago by
 Commit set to 465d83c199cbe9f399574db2e3d79708ae118ad8
comment:3 followup: ↓ 4 Changed 3 years ago by
See also #18781.
comment:4 in reply to: ↑ 3 Changed 3 years ago by
comment:5 Changed 3 years ago by
Can we at least put sageunzip into build/bin/ and not expose it via a sage unzip command line argument? It has no mathematical purpose, its just an internal tool for building Sage packages.
comment:6 followup: ↓ 8 Changed 3 years ago by
And I agree that there are lots of stupid command line options like sage twisted
. I don't think that means that we should add more outofscope commandline options.
comment:7 Changed 3 years ago by
I thought that it would make more sense in the general bin folder. This is where one would find 'unzip' if we had chosen to package it.
As Dima raised, one can already find many nonmathematical 'utilities' in the general bin/ folder. Some examples: g++,cython,cythonize,python,scons,git, ...
comment:8 in reply to: ↑ 6 Changed 3 years ago by
And I agree that there are lots of stupid command line options like
sage twisted
. I don't think that means that we should add more outofscope commandline options.
Oh. Well I have no strong objection to the removal of sage unzip
. I just thought that all sagesomething had to be exposed as "sage something". How would you want it to appear?
Nathann
comment:9 followup: ↓ 10 Changed 3 years ago by
There is no reason to expose everything as commandline option. There is no sage fixpkgchecksums
(i hope). The script using sageunzip can just call it directly.
comment:10 in reply to: ↑ 9 Changed 3 years ago by
There is no reason to expose everything as commandline option. There is no
sage fixpkgchecksums
(i hope).
Err... That's #18947.
The script using sageunzip can just call it directly.
Okayokay. So I'll remove that line, I do not mind much.
Nathann
comment:11 Changed 3 years ago by
 Commit changed from 465d83c199cbe9f399574db2e3d79708ae118ad8 to 35f2e34b3bd17a3ca7d57a6fe5c1f25c2498974e
Branch pushed to git repo; I updated commit sha1. New commits:
35f2e34  trac #19484: No sage unzip

comment:12 Changed 3 years ago by
 Commit changed from 35f2e34b3bd17a3ca7d57a6fe5c1f25c2498974e to 727ac938b282c541f489d273c2a3cf7bbc96fc2e
Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:
727ac93  trac #19484: sageunzip

comment:13 Changed 3 years ago by
 Reviewers set to Volker Braun
 Status changed from needs_review to positive_review
comment:14 Changed 3 years ago by
Cooool! Thanks,
Nathann
comment:15 Changed 3 years ago by
 Branch changed from public/19484 to 727ac938b282c541f489d273c2a3cf7bbc96fc2e
 Resolution set to fixed
 Status changed from positive_review to closed
Branch pushed to git repo; I updated commit sha1. New commits:
trac #19484  sage unzip