Opened 3 years ago

Closed 3 years ago

#19471 closed enhancement (fixed)

COIN backend: More basis status and tableau data functions

Reported by: mkoeppe Owned by:
Priority: major Milestone: sage-6.10
Component: numerical Keywords: lp
Cc: yzh, ncohen, vdelecroix, dimpase Merged in:
Authors: Aedi Wang, Wang de Mao Reviewers: Dima Pasechnik
Report Upstream: N/A Work issues:
Branch: cef0fc3 (Commits) Commit: cef0fc3d749c3fc106b862c1454bef7f47bba618
Dependencies: Stopgaps:

Description (last modified by mkoeppe)

This is a follow-up to #18763.

It adds the missing get_row_price and get_reduced_cost functions.

These are the remaining functions necessary to implement #18804.

Change History (16)

comment:1 Changed 3 years ago by mkoeppe

  • Description modified (diff)

comment:2 Changed 3 years ago by zwang

  • Branch set to u/zwang/COIN_backend_More_basis_status_and_tableau_data_functions

comment:3 Changed 3 years ago by git

  • Commit set to 6373b5f4a5d5bc5d9555d462533c968099c3ac5c

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

​6373b5fMore basis status and tableau data functions

comment:4 Changed 3 years ago by mkoeppe

  • Cc dimpase added
  • Status changed from new to needs_review

comment:5 Changed 3 years ago by dimpase

what is the meaning of the weird string after fails here:

raise MIPSolverException('CBC : Signal sent, getBasics() fails eairsntiaerksivbeqyafutboueqtoduboariythdb')

comment:6 Changed 3 years ago by git

  • Commit changed from 6373b5f4a5d5bc5d9555d462533c968099c3ac5c to 483c528d0fe4fed73cc42506103d9e4d74716d14

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

​483c528More basis status and tableau data functions

comment:7 Changed 3 years ago by mkoeppe

Apparently that was the cat. Fixed.

comment:8 Changed 3 years ago by dimpase

  • Authors changed from Aedi Wang to Aedi Wang, Katze von Koeppe
  • Reviewers set to Dima Pasechnik

comment:9 Changed 3 years ago by dimpase

  • Status changed from needs_review to positive_review

comment:10 Changed 3 years ago by mkoeppe

  • Authors changed from Aedi Wang, Katze von Koeppe to Aedi Wang, Wang de Mao

Thanks for the review! Wrong cat, though; fixed that.

comment:11 Changed 3 years ago by vbraun

  • Status changed from positive_review to needs_work 
sage -t --long src/sage/numerical/backends/coin_backend.pyx
**********************************************************************
File "src/sage/numerical/backends/coin_backend.pyx", line 1595, in sage.numerical.backends.coin_backend.CoinBackend.get_basics
Failed example:
    p.solve()
Exception raised:
    Traceback (most recent call last):
      File "/Users/buildslave-sage/slave/sage_git/build/local/lib/python2.7/site-packages/sage/doctest/forker.py", line 496, in _run
        self.compile_and_execute(example, compiler, test.globs)
      File "/Users/buildslave-sage/slave/sage_git/build/local/lib/python2.7/site-packages/sage/doctest/forker.py", line 858, in compile_and_execute
        exec(compiled, globs)
      File "<doctest sage.numerical.backends.coin_backend.CoinBackend.get_basics[1]>", line 1, in <module>
        p.solve()
    NameError: name 'p' is not defined
**********************************************************************
File "src/sage/numerical/backends/coin_backend.pyx", line 1597, in sage.numerical.backends.coin_backend.CoinBackend.get_basics
Failed example:
    p.get_basics()
Exception raised:
    Traceback (most recent call last):
      File "/Users/buildslave-sage/slave/sage_git/build/local/lib/python2.7/site-packages/sage/doctest/forker.py", line 496, in _run
        self.compile_and_execute(example, compiler, test.globs)
      File "/Users/buildslave-sage/slave/sage_git/build/local/lib/python2.7/site-packages/sage/doctest/forker.py", line 858, in compile_and_execute
        exec(compiled, globs)
      File "<doctest sage.numerical.backends.coin_backend.CoinBackend.get_basics[2]>", line 1, in <module>
        p.get_basics()
    NameError: name 'p' is not defined
**********************************************************************
File "src/sage/numerical/backends/coin_backend.pyx", line 1634, in sage.numerical.backends.coin_backend.CoinBackend.get_row_price
Failed example:
    p.solve()
Exception raised:
    Traceback (most recent call last):
      File "/Users/buildslave-sage/slave/sage_git/build/local/lib/python2.7/site-packages/sage/doctest/forker.py", line 496, in _run
        self.compile_and_execute(example, compiler, test.globs)
      File "/Users/buildslave-sage/slave/sage_git/build/local/lib/python2.7/site-packages/sage/doctest/forker.py", line 858, in compile_and_execute
        exec(compiled, globs)
      File "<doctest sage.numerical.backends.coin_backend.CoinBackend.get_row_price[1]>", line 1, in <module>
        p.solve()
    NameError: name 'p' is not defined
**********************************************************************
File "src/sage/numerical/backends/coin_backend.pyx", line 1636, in sage.numerical.backends.coin_backend.CoinBackend.get_row_price
Failed example:
    p.get_row_price()
Exception raised:
    Traceback (most recent call last):
      File "/Users/buildslave-sage/slave/sage_git/build/local/lib/python2.7/site-packages/sage/doctest/forker.py", line 496, in _run
        self.compile_and_execute(example, compiler, test.globs)
      File "/Users/buildslave-sage/slave/sage_git/build/local/lib/python2.7/site-packages/sage/doctest/forker.py", line 858, in compile_and_execute
        exec(compiled, globs)
      File "<doctest sage.numerical.backends.coin_backend.CoinBackend.get_row_price[2]>", line 1, in <module>
        p.get_row_price()
    NameError: name 'p' is not defined
**********************************************************************
File "src/sage/numerical/backends/coin_backend.pyx", line 1671, in sage.numerical.backends.coin_backend.CoinBackend.get_reduced_cost
Failed example:
    p.solve()
Exception raised:
    Traceback (most recent call last):
      File "/Users/buildslave-sage/slave/sage_git/build/local/lib/python2.7/site-packages/sage/doctest/forker.py", line 496, in _run
        self.compile_and_execute(example, compiler, test.globs)
      File "/Users/buildslave-sage/slave/sage_git/build/local/lib/python2.7/site-packages/sage/doctest/forker.py", line 858, in compile_and_execute
        exec(compiled, globs)
      File "<doctest sage.numerical.backends.coin_backend.CoinBackend.get_reduced_cost[1]>", line 1, in <module>
        p.solve()
    NameError: name 'p' is not defined
**********************************************************************
File "src/sage/numerical/backends/coin_backend.pyx", line 1673, in sage.numerical.backends.coin_backend.CoinBackend.get_reduced_cost
Failed example:
    p.get_reduced_cost()
Exception raised:
    Traceback (most recent call last):
      File "/Users/buildslave-sage/slave/sage_git/build/local/lib/python2.7/site-packages/sage/doctest/forker.py", line 496, in _run
        self.compile_and_execute(example, compiler, test.globs)
      File "/Users/buildslave-sage/slave/sage_git/build/local/lib/python2.7/site-packages/sage/doctest/forker.py", line 858, in compile_and_execute
        exec(compiled, globs)
      File "<doctest sage.numerical.backends.coin_backend.CoinBackend.get_reduced_cost[2]>", line 1, in <module>
        p.get_reduced_cost()
    NameError: name 'p' is not defined
**********************************************************************
3 items had failures:
   2 of   4 in sage.numerical.backends.coin_backend.CoinBackend.get_basics
   2 of   4 in sage.numerical.backends.coin_backend.CoinBackend.get_reduced_cost
   2 of   4 in sage.numerical.backends.coin_backend.CoinBackend.get_row_price
    [45 tests, 6 failures, 0.04 s]

comment:12 Changed 3 years ago by git

  • Commit changed from 483c528d0fe4fed73cc42506103d9e4d74716d14 to cef0fc3d749c3fc106b862c1454bef7f47bba618

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

​cef0fc3More basis status and tableau data functions

comment:13 Changed 3 years ago by zwang

  • Status changed from needs_work to needs_review

fixed doc string

comment:14 Changed 3 years ago by dimpase

please don't overwrite the previous commits in such cases - it makes it hard to see what you changed...

comment:15 Changed 3 years ago by dimpase

  • Status changed from needs_review to positive_review

comment:16 Changed 3 years ago by vbraun

  • Branch changed from u/zwang/COIN_backend_More_basis_status_and_tableau_data_functions to cef0fc3d749c3fc106b862c1454bef7f47bba618
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.