Opened 4 years ago

Closed 4 years ago

#19465 closed defect (fixed)

Stopgap for #16397 (symbolic cmp)

Reported by: rws Owned by:
Priority: blocker Milestone: sage-duplicate/invalid/wontfix
Component: symbolics Keywords:
Cc: Merged in:
Authors: Reviewers: Volker Braun
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Change History (9)

comment:1 Changed 4 years ago by rws

  • Branch set to u/rws/stopgap_for__16397__symbolic_cmp_

comment:2 Changed 4 years ago by rws

  • Commit set to 39804516fdd829618c46da1c7bf3f8116affd37f
  • Priority changed from major to blocker
  • Status changed from new to needs_review

New commits:

398045119465: stopgap for 16397

comment:3 Changed 4 years ago by jdemeyer

  • Status changed from needs_review to needs_work

Please be more specific than "this code".

comment:4 Changed 4 years ago by jdemeyer

Also: author name?

comment:5 Changed 4 years ago by git

  • Commit changed from 39804516fdd829618c46da1c7bf3f8116affd37f to 57c6cad01bb755a1911e8be83cfc20a9bfda99b8

Branch pushed to git repo; I updated commit sha1. New commits:

57c6cad16397: cosmetics

comment:6 Changed 4 years ago by rws

  • Authors set to Ralf Stephan
  • Status changed from needs_work to needs_review

New commits:

57c6cad16397: cosmetics

comment:7 Changed 4 years ago by vbraun

Any progress here?

Equality-comparison is afaik just fine, at the very least the stopgap should only warn if the return value is non-zero. Also, a more informative wording might be e.g.

Symbolic expression compare by the printing order, not by mathematical inequality

comment:8 Changed 4 years ago by rws

  • Authors Ralf Stephan deleted
  • Branch u/rws/stopgap_for__16397__symbolic_cmp_ deleted
  • Commit 57c6cad01bb755a1911e8be83cfc20a9bfda99b8 deleted
  • Milestone changed from sage-6.10 to sage-duplicate/invalid/wontfix
  • Status changed from needs_review to positive_review

Instead of a stopgap please review #16397.

comment:9 Changed 4 years ago by vbraun

  • Resolution set to fixed
  • Reviewers set to Volker Braun
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.