Opened 7 years ago

Closed 2 years ago

Last modified 2 years ago

#19448 closed enhancement (fixed)

Improvements to submodules

Reported by: Travis Scrimshaw Owned by: Travis Scrimshaw
Priority: major Milestone: sage-9.2
Component: categories Keywords: sd109
Cc: John Palmieri, Nicolas M. Thiéry, Darij Grinberg, Aladin Virmaux, Frédéric Chapoton, Matthias Köppe Merged in:
Authors: Travis Scrimshaw Reviewers: Simon Brandhorst
Report Upstream: N/A Work issues:
Branch: d8a1c50 (Commits, GitHub, GitLab) Commit:
Dependencies: Stopgaps:

Status badges

Description

We implement the lift map as a coercion map from a submodule and extend the submodule to work over modules with infinite bases.

Change History (15)

comment:1 Changed 7 years ago by Travis Scrimshaw

Branch: public/categories/improve_submodules-19448
Cc: Darij Grinberg Aladin Virmaux added
Commit: 98dc756161108b5d01280c54d7b475ab4dd59489
Status: newneeds_review

One thing that might be slightly controversial is that I construct an explicit ordering of elements used after the echelonization. However, this is needed to be stored in the submodule because if the ordering of the ambient changes (which it can by the set_order method), this could break the triangularity of the lift map. This also allowed me to construct submodules of infinite-dimensional modules.


New commits:

98dc756Improvements to submodules.

comment:2 Changed 7 years ago by Travis Scrimshaw

Milestone: sage-6.10sage-7.2

comment:3 Changed 7 years ago by git

Commit: 98dc756161108b5d01280c54d7b475ab4dd594898006b8eab80e772ab46bd440429703717869f5cf

Branch pushed to git repo; I updated commit sha1. New commits:

8006b8eMerge branch 'public/categories/improve_submodules-19448' of trac.sagemath.org:sage into public/categories/improve_submodules-19448

comment:4 Changed 6 years ago by Clemens Heuberger

Status: needs_reviewneeds_work

merge conflict

comment:5 Changed 5 years ago by git

Commit: 8006b8eab80e772ab46bd440429703717869f5cfd4838df190198c014f700c8dfea4062c7cf82a62

Branch pushed to git repo; I updated commit sha1. New commits:

147583bMerge branch 'public/categories/improve_submodules-19448' of git://trac.sagemath.org/sage into public/categories/improve_submodules-19448
d4838dfRemoving cmp for key.

comment:6 Changed 5 years ago by Travis Scrimshaw

Cc: Frédéric Chapoton added
Milestone: sage-7.2sage-8.0
Status: needs_workneeds_review

Actually, the more I think about it, the more I am for fixing the ordering of the submodule basis as the submodule is defined by a matrix, where there is an implicit ordering of the basis already in there.

comment:7 Changed 3 years ago by Simon Brandhorst

Status: needs_reviewneeds_work

failing doctest

comment:8 Changed 2 years ago by git

Commit: d4838df190198c014f700c8dfea4062c7cf82a621267467269fc838d5c385e13973b6791b1dc3d79

Branch pushed to git repo; I updated commit sha1. New commits:

09f8caaMerge branch 'public/categories/improve_submodules-19448' of git://trac.sagemath.org/sage into public/categories/improve_submodules-19448
1267467Fixing failures and allowing echelon_form to handle oo-dim modules.

comment:9 Changed 2 years ago by Travis Scrimshaw

Cc: Matthias Köppe added
Milestone: sage-8.0sage-9.2
Status: needs_workneeds_review

This should now pass all tests. I also extended the echelon_form to handle the case when the ambient module is infinite dimensional.

comment:10 Changed 2 years ago by Matthias Köppe

Keywords: sd109 added

comment:11 Changed 2 years ago by git

Commit: 1267467269fc838d5c385e13973b6791b1dc3d79d8a1c50f2044b42edd8f136bc89168a1eb858b6c

Branch pushed to git repo; I updated commit sha1. New commits:

d8a1c50Fixing doctests and making _vector_ and from_vector methods more consistent.

comment:12 Changed 2 years ago by Travis Scrimshaw

So doctests were failing elsewhere because _support_order was also an attribute used by the submodules. So I refactored the method to now be called _compute_support_order. I also found some other issues with to/from_vector not being consistent in their parameters. Doctests that were failing now pass.

comment:13 Changed 2 years ago by Simon Brandhorst

Reviewers: Simon Brandhorst
Status: needs_reviewpositive_review

looks reasonable to me.

comment:14 Changed 2 years ago by Volker Braun

Branch: public/categories/improve_submodules-19448d8a1c50f2044b42edd8f136bc89168a1eb858b6c
Resolution: fixed
Status: positive_reviewclosed

comment:15 Changed 2 years ago by Matthias Köppe

Commit: d8a1c50f2044b42edd8f136bc89168a1eb858b6c
Note: See TracTickets for help on using tickets.