Opened 6 years ago

Closed 6 years ago

#19443 closed defect (fixed)

Don't require re-running configure when adding/removing packages

Reported by: vbraun Owned by:
Priority: major Milestone: sage-6.10
Component: build: configure Keywords:
Cc: jdemeyer Merged in:
Authors: Volker Braun, Jeroen Demeyer Reviewers: Emmanuel Charpentier
Report Upstream: N/A Work issues:
Branch: 4786d52 (Commits, GitHub, GitLab) Commit: 4786d52f04c7201d932c7c776a6e1d58169bc463
Dependencies: Stopgaps:

Status badges

Description (last modified by vbraun)

Since there is already a makefile target to re-run configure make it depend on the package metadata.

Change History (18)

comment:1 Changed 6 years ago by vbraun

  • Branch set to u/vbraun/don_t_require_re_running_configure_when_adding_removing_packages

comment:2 Changed 6 years ago by vbraun

  • Commit set to 6b1fe558ed1a0faeebd64cfae1567139fde05c8a
  • Description modified (diff)

New commits:

5069144Rerun configure if package metadata changed
6b1fe55Improve the configure dependencies

comment:3 Changed 6 years ago by vbraun

  • Authors set to Volker Braun
  • Cc jdemeyer added
  • Status changed from new to needs_review

comment:4 Changed 6 years ago by jdemeyer

  • Status changed from needs_review to needs_work

Can you undo the changes to the m4 files, it conflicts with #19298.

Initially I was afraid about the performance of running this find command all the time, but it's not really a problem.

Should we remove ./configure from the developer's documentation? Probably yes.

comment:5 Changed 6 years ago by git

  • Commit changed from 6b1fe558ed1a0faeebd64cfae1567139fde05c8a to 5069144fcd912aa755f18cefbef74d517bc81128

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

comment:6 follow-up: Changed 6 years ago by vbraun

The long-term goal should probably be to have everybody onboard with ./configure && make, so I'm happy to leave it in the developer docs.

comment:7 Changed 6 years ago by vbraun

  • Status changed from needs_work to needs_review

comment:8 in reply to: ↑ 6 Changed 6 years ago by jdemeyer

Replying to vbraun:

The long-term goal should probably be to have everybody onboard with ./configure && make, so I'm happy to leave it in the developer docs.

On the other hand, if this branch makes ./configure not needed, I don't see the point of keeping it in the manual: it's only confusing.

comment:9 Changed 6 years ago by vbraun

I don't particularly care either way; Feel free to add a commit or do it on a separate ticket if you really want to change the docs.

comment:10 Changed 6 years ago by jdemeyer

  • Branch changed from u/vbraun/don_t_require_re_running_configure_when_adding_removing_packages to u/jdemeyer/don_t_require_re_running_configure_when_adding_removing_packages

comment:11 Changed 6 years ago by jdemeyer

  • Authors changed from Volker Braun to Volker Braun, Jeroen Demeyer
  • Commit changed from 5069144fcd912aa755f18cefbef74d517bc81128 to 4786d52f04c7201d932c7c776a6e1d58169bc463

New commits:

4786d52Rerun configure if package metadata changed

comment:12 Changed 6 years ago by vbraun

Are you finished?

comment:13 Changed 6 years ago by charpent

  • Reviewers set to charpent
  • Status changed from needs_review to positive_review

On top of 6.10beta2, merging #19443 allows to merge #19469 successfully without having to ./configure again.

Passes ptestlong ==> positive_review.

comment:14 Changed 6 years ago by cheuberg

IIRC, the trac reviewers field must contain the full name of the reviewer, not the username.

comment:15 Changed 6 years ago by jdemeyer

  • Status changed from positive_review to needs_info

Reviewer name?

comment:16 Changed 6 years ago by charpent

  • Reviewers changed from charpent to Emmanuel Charpentier
  • Status changed from needs_info to needs_review

comment:17 Changed 6 years ago by charpent

  • Status changed from needs_review to positive_review

comment:18 Changed 6 years ago by vbraun

  • Branch changed from u/jdemeyer/don_t_require_re_running_configure_when_adding_removing_packages to 4786d52f04c7201d932c7c776a6e1d58169bc463
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.