Opened 4 years ago

Closed 4 years ago

#19436 closed defect (fixed)

fixup of 19431: convert asymptotic expansion to the symbolic ring

Reported by: dkrenn Owned by:
Priority: major Milestone: sage-6.10
Component: asymptotic expansions Keywords:
Cc: behackl, cheuberg, rws Merged in:
Authors: Daniel Krenn Reviewers: Clemens Heuberger
Report Upstream: N/A Work issues:
Branch: ee52932 (Commits) Commit: ee5293298a509cb15da000f87ba25adb75f4f63d
Dependencies: #19431 Stopgaps:

Description

#19431 changed SymbolicRing._element_constructor_ which was not needed. A method _symbolic_ suffices in the AsymptoticRing. An additional parameter R in .symbolic_expression will be needed to make it work.

Change History (5)

comment:1 Changed 4 years ago by dkrenn

  • Branch set to u/dkrenn/asy-to-SR

comment:2 Changed 4 years ago by dkrenn

  • Authors set to Daniel Krenn
  • Commit set to ee5293298a509cb15da000f87ba25adb75f4f63d
  • Status changed from new to needs_review

Last 10 new commits:

5327238doctests: rewrite >>... to >...>
ef4ebb1rewrite main substitution method
2f434d7write doc and many doctests for substitute
875542dwrite AsymptoticExpansion.symbolic_expression
5ac0feaextend SR._element_constructor_ to accept asymptotic expansions
fa814b0Trac #19431: merge 6.10.beta0
6a6efc4introduce parameter R in .symbolic_expression
f39b942simplify SR._element_constructor
5c3cba3fix checks whether parent is SR to check if instance of SymbolicRing
ee52932fixup and doctest of parameter R in .symbolic_expression

comment:3 Changed 4 years ago by dkrenn

  • Cc rws added

comment:4 Changed 4 years ago by cheuberg

  • Reviewers set to Clemens Heuberger
  • Status changed from needs_review to positive_review

LGTM.

doctests pass, documentation builds, code seems to be fine.

comment:5 Changed 4 years ago by vbraun

  • Branch changed from u/dkrenn/asy-to-SR to ee5293298a509cb15da000f87ba25adb75f4f63d
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.