Opened 5 years ago

Closed 5 years ago

#19431 closed enhancement (fixed)

convert asymptotic expansion to the symbolic ring

Reported by: dkrenn Owned by:
Priority: major Milestone: sage-6.10
Component: asymptotic expansions Keywords:
Cc: behackl, cheuberg Merged in:
Authors: Daniel Krenn Reviewers: Clemens Heuberger, Ralf Stephan
Report Upstream: N/A Work issues:
Branch: fa814b0 (Commits) Commit: fa814b0680e8f7edc2ed3e181f5b9750678db04f
Dependencies: #19305 Stopgaps:


Make conversion from asymptotic expansions to symbolic expressions possible.

Change History (8)

comment:1 Changed 5 years ago by dkrenn

  • Branch set to u/dkrenn/asy-to-SR

comment:2 Changed 5 years ago by dkrenn

  • Authors set to Daniel Krenn
  • Commit set to 5ac0feaa2faebd303bd3d4ed53ce40b60c22311c
  • Status changed from new to needs_review

Last 10 new commits:

17d0e2bdocstrings and tests in _substitute_ of growth groups
d2a599frewrite code of _substitute_ in term monoids
204e47cdocstrings of _substitute_ in term monoids
5cd22bfcomplete _substitute_ of asymptotic ring
9d3a6e3let __eq__ deal with noncomparable elements
5327238doctests: rewrite >>... to >...>
ef4ebb1rewrite main substitution method
2f434d7write doc and many doctests for substitute
875542dwrite AsymptoticExpansion.symbolic_expression
5ac0feaextend SR._element_constructor_ to accept asymptotic expansions

comment:3 Changed 5 years ago by rws

Branch does not merge cleanly with develop.

comment:4 Changed 5 years ago by cheuberg

  • Branch changed from u/dkrenn/asy-to-SR to u/cheuberg/asy-to-SR

comment:5 Changed 5 years ago by cheuberg

  • Commit changed from 5ac0feaa2faebd303bd3d4ed53ce40b60c22311c to fa814b0680e8f7edc2ed3e181f5b9750678db04f
  • Reviewers set to Clemens Heuberger

Branch LGTM, doctests pass, documentation builds. I merged 6.10.beta0. This needs cross-review. Apart from that, consider this as a positive review.

New commits:

fa814b0Trac #19431: merge 6.10.beta0

comment:6 Changed 5 years ago by rws

I already had a look but will wait for patchbot.

comment:7 Changed 5 years ago by rws

  • Reviewers changed from Clemens Heuberger to Clemens Heuberger, Ralf Stephan
  • Status changed from needs_review to positive_review

OK, fine modulo the dependencies (which were already reviewed). Thanks for your work.

comment:8 Changed 5 years ago by vbraun

  • Branch changed from u/cheuberg/asy-to-SR to fa814b0680e8f7edc2ed3e181f5b9750678db04f
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.