Opened 4 years ago

Last modified 3 months ago

#19426 needs_work enhancement

AsymptoticRing: convert Orders of symbolic ring

Reported by: dkrenn Owned by:
Priority: major Milestone: sage-8.2
Component: asymptotic expansions Keywords: beginner
Cc: behackl Merged in:
Authors: Eran Assaf Reviewers: Benjamin Hackl
Report Upstream: N/A Work issues: rebase
Branch: u/assaferan/asymptoticring__convert_orders_of_symbolic_ring (Commits) Commit: 90152f3b60b3d756fe8088ecc0f9277dc195d25d
Dependencies: #19083, #19425 Stopgaps:

Description (last modified by cheuberg)

Implement conversion from Order(...) to asymptotic rings.

(There seems to be a bug in SR (#19425) which has to be solved first.)

Change History (9)

comment:1 Changed 4 years ago by cheuberg

  • Description modified (diff)

comment:2 Changed 4 years ago by cheuberg

  • Cc behackl added
  • Dependencies changed from #19083, #19424 to #19083, #19425

comment:3 Changed 4 years ago by dkrenn

  • Keywords beginner added

comment:4 Changed 20 months ago by assaferan

  • Branch set to u/assaferan/asymptoticring__convert_orders_of_symbolic_ring

comment:5 Changed 20 months ago by assaferan

  • Authors set to Eran Assaf
  • Commit set to 45ec3d759f5146c65f0be1bd001ca22a2385b6c0
  • Status changed from new to needs_review

New commits:

bd4a461Changed brial installation to support cygwin 64-bit with the new limits.h
60c5606Fixed Ticket #19426 - Implemented conversion from Order(...) to asymptotic rings.
cd2f1a4Added conversion from Symbolic Order to Asymptotic Ring.
45ec3d7Added an appropriate doctest

comment:6 Changed 20 months ago by behackl

  • Milestone changed from sage-6.10 to sage-8.2
  • Reviewers set to Benjamin Hackl
  • Status changed from needs_review to needs_work

Hi! Your basic approach looks good, however, you should merge the latest beta (8.2.beta8) into your branch and fix the resulting merge conflict with your adaption of the brial configuration. (This issue has been fixed in #24860, which is merged in beta8.)

As a suggestion: you should keep fixes for unrelated problems (like in this case the brial problem) separate from the code for this ticket (basically, separate fixes deserve separate tickets).

I'll review this as soon as the conflict is resolved.

comment:7 Changed 20 months ago by git

  • Commit changed from 45ec3d759f5146c65f0be1bd001ca22a2385b6c0 to 90152f3b60b3d756fe8088ecc0f9277dc195d25d

Branch pushed to git repo; I updated commit sha1. New commits:

90152f3merged latest beta code with mine

comment:8 Changed 20 months ago by assaferan

  • Status changed from needs_work to needs_review

Hi! I've fixed the conflict and committed the changes.

In principal, I agree with your suggestion. The problem was I could not build sage on my PC without fixing this problem, and it took a while until I could get everything to work (trac user, git, etc.).

Anyway, hopefully it can be reviewed now. Thanks, Eran

comment:9 Changed 3 months ago by gh-RelationaleDB

  • Status changed from needs_review to needs_work
  • Work issues set to rebase

merge conflict

Note: See TracTickets for help on using tickets.