Opened 5 years ago
Closed 5 years ago
#19417 closed enhancement (fixed)
A (Di)Graph([V,E]) constructor
Reported by: | ncohen | Owned by: | |
---|---|---|---|
Priority: | major | Milestone: | sage-6.10 |
Component: | graph theory | Keywords: | |
Cc: | tscrim | Merged in: | |
Authors: | Nathann Cohen | Reviewers: | Travis Scrimshaw |
Report Upstream: | N/A | Work issues: | |
Branch: | b8094cb (Commits) | Commit: | b8094cb4e3c8fc23816c74c3b27a4226cb7ce86c |
Dependencies: | #19390 | Stopgaps: |
Description
As requested by Travis.
Nathann
Change History (7)
comment:1 Changed 5 years ago by
- Branch set to u/ncohen/19417
- Commit set to 374cf4f1b325ea0dc4ce2d8cf56561334576d612
- Status changed from new to needs_review
comment:2 Changed 5 years ago by
- Commit changed from 374cf4f1b325ea0dc4ce2d8cf56561334576d612 to b0f04efbbf6169bc1f1ad856bfc67c5e0ddfb95e
Branch pushed to git repo; I updated commit sha1. New commits:
b0f04ef | trac #19417: Merged with 6.10.beta1
|
comment:3 Changed 5 years ago by
- Branch changed from u/ncohen/19417 to u/tscrim/VE_constructor-19417
- Commit changed from b0f04efbbf6169bc1f1ad856bfc67c5e0ddfb95e to 94b44085f792f5482def3a6b8d3df3ec69867fb8
- Reviewers set to Travis Scrimshaw
Thanks for doing this Nathann. My first commit fixes the failing doctests and give a reason why I wanted this constructor. The other commit is an attempt by me to make the [V, E]
constructor better differentiate between the list of edges input. If you disagree with it, feel free to just revert back to the first commit and set a positive review.
New commits:
b8094cb | Doing some things with the new constructor for robustness (and why I asked for it).
|
94b4408 | Attempt at making the (di)graph [V, E] recognition more robust.
|
comment:4 Changed 5 years ago by
No, sorry. No linear-time test to detect an input format.
Nathann
comment:5 Changed 5 years ago by
Scuse me, that's actually quadratic. Just no.
comment:6 Changed 5 years ago by
- Branch changed from u/tscrim/VE_constructor-19417 to u/ncohen/19417
- Commit changed from 94b44085f792f5482def3a6b8d3df3ec69867fb8 to b8094cb4e3c8fc23816c74c3b27a4226cb7ce86c
- Status changed from needs_review to positive_review
I am okay with this branch without the last commit. As you proposed, I set ths ticket to positive_review
.
Nathann
comment:7 Changed 5 years ago by
- Branch changed from u/ncohen/19417 to b8094cb4e3c8fc23816c74c3b27a4226cb7ce86c
- Resolution set to fixed
- Status changed from positive_review to closed
Last 10 new commits:
trac #19381: dict of lists
trac #19381: dig6
trac #19381: Typo
trac #19385: Refactor DiGraph.__init__
trac #19385: Dictionary of lists for a digraph with labelled multiple edges. How I wish I could forget those stupid things.
trac #19390: Update the documentation of Graph/DiGraph constructors
trac #19390: Merged with 6.9
trac #19390: Typos
trac #19390: add a *symmetric* somewhere in the doc
trac #19417: A (Di)Graph([V,E]) constructor