Opened 4 years ago

Closed 4 years ago

#19389 closed enhancement (fixed)

Methods on alternating sign matrices and fully packed loops related to link patterns

Reported by: jessicapalencia Owned by:
Priority: major Milestone: sage-6.9
Component: combinatorics Keywords: asm, fpl
Cc: tscrim, kdilks Merged in:
Authors: Jessica Striker Reviewers: Kevin Dilks
Report Upstream: N/A Work issues:
Branch: f1f05ef (Commits) Commit: f1f05ef2e5c826c7a9844afa5d916d7281b5ec16
Dependencies: Stopgaps:

Description

Added 'gyration' method to fully packed loops. Added 'link pattern' method to alternating sign matrices. Added 'to_link_pattern_dyck_word' method to alternating sign matrices.

Change History (14)

comment:1 Changed 4 years ago by jessicapalencia

  • Branch set to u/jessicapalencia/19389
  • Commit set to 9ccedce4c0811fb8165879d10f447b5ffa3bdc08
  • Status changed from new to needs_review

New commits:

7395b58Map from a noncrossing perfect matching to a noncrossing set partition
35a422cchanged first line of doc string to be one sentence
6490916added gyration to FullyPackedLoop and link_pattern to AlternatingSignMatrix
c3e1902Added a map from alternating sign matrices to Dyck words via the link pattern
9ccedceAdded another doc test

comment:2 Changed 4 years ago by kdilks

Docstring for gyration() in alternating_sign_matrix.py needs a period at the end.

Maybe shorten the name of to_link_pattern_dyck_word() to just to_dyck_word()? As far as I know, the only natural map to dyck words from ASMs is via the link pattern. If another such map is ever discovered/implemented, then we could lengthen the name, or just distinguish between them via an optional parameter.

comment:3 Changed 4 years ago by git

  • Commit changed from 9ccedce4c0811fb8165879d10f447b5ffa3bdc08 to ef2220843f6bc126070520797e799b45a7650147

Branch pushed to git repo; I updated commit sha1. New commits:

ef22208made a single to_dyck_word method with two different algorithms, 'last diagonal' and 'link pattern'

comment:4 Changed 4 years ago by jessicapalencia

There actually is already a to_dyck_word method, so I modified that one to include both methods of obtaining a Dyck word, dependent on a parameter.


New commits:

ef22208made a single to_dyck_word method with two different algorithms, 'last diagonal' and 'link pattern'

comment:5 Changed 4 years ago by kdilks

Ignore comment about missing period, I fail at reading diff.

First sentence of doc for to_dyck_word() should be a single compact sentence, caveats/explanations should be pushed to a second paragraph, or included in INPUT:.

Methods should be last_diagonal and link_pattern.

Lastly, there should be some kind of error raised if the parameter is set to be something other than one of those two options.

comment:6 Changed 4 years ago by git

  • Commit changed from ef2220843f6bc126070520797e799b45a7650147 to 535e32f11b264c9cb806ea07cda5ae4417dd2485

Branch pushed to git repo; I updated commit sha1. New commits:

535e32fedit of doc, input, and value error on to_dyck_word

comment:7 Changed 4 years ago by kdilks

  • Status changed from needs_review to positive_review

comment:8 Changed 4 years ago by vbraun

  • Status changed from positive_review to needs_work

Reviewer name is missing

comment:9 Changed 4 years ago by kdilks

  • Reviewers set to Kevin Dilks
  • Status changed from needs_work to positive_review

comment:10 Changed 4 years ago by vbraun

  • Status changed from positive_review to needs_work

Documentation doesn't build

comment:11 Changed 4 years ago by kdilks

  • Branch changed from u/jessicapalencia/19389 to u/kdilks/19389

comment:12 Changed 4 years ago by kdilks

  • Commit changed from 535e32f11b264c9cb806ea07cda5ae4417dd2485 to f1f05ef2e5c826c7a9844afa5d916d7281b5ec16

Duplicate citation (reference for Wieland was already in fully packed loops).


New commits:

f1f05efremoved duplicate citation

comment:13 Changed 4 years ago by kdilks

  • Status changed from needs_work to positive_review

comment:14 Changed 4 years ago by vbraun

  • Branch changed from u/kdilks/19389 to f1f05ef2e5c826c7a9844afa5d916d7281b5ec16
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.