Opened 7 years ago

Closed 7 years ago

Last modified 6 years ago

#19361 closed enhancement (fixed)

Move refine_root() to a new file

Reported by: jdemeyer Owned by:
Priority: major Milestone: sage-6.10
Component: algebra Keywords:
Cc: Merged in:
Authors: Jeroen Demeyer Reviewers: Julian Rueth
Report Upstream: N/A Work issues:
Branch: 2049f5a (Commits, GitHub, GitLab) Commit:
Dependencies: Stopgaps:

Status badges

Description (last modified by jdemeyer)

The function refine_root() from complex_roots.py is a pretty general Newton­-Raphson implementation. In light of further changes at #19362, we move this to a new Cython file.

There are no changes at all to the code.

Change History (7)

comment:1 Changed 7 years ago by jdemeyer

  • Branch set to u/jdemeyer/move_refine_root___to_a_new_file

comment:2 Changed 7 years ago by jdemeyer

  • Commit set to 2049f5a4f3143479395827f1ab82c0a0b39089bc
  • Status changed from new to needs_review

New commits:

2049f5aMove refine_root() to refine_root.pyx

comment:3 Changed 7 years ago by jdemeyer

  • Description modified (diff)
  • Milestone changed from sage-6.9 to sage-6.10

comment:4 Changed 7 years ago by jdemeyer

  • Description modified (diff)

comment:5 Changed 7 years ago by saraedum

  • Reviewers set to Julian Rüth
  • Status changed from needs_review to positive_review

comment:6 Changed 7 years ago by vbraun

  • Branch changed from u/jdemeyer/move_refine_root___to_a_new_file to 2049f5a4f3143479395827f1ab82c0a0b39089bc
  • Resolution set to fixed
  • Status changed from positive_review to closed

comment:7 Changed 6 years ago by jdemeyer

  • Commit 2049f5a4f3143479395827f1ab82c0a0b39089bc deleted
  • Reviewers changed from Julian Rüth to Julian Rueth
Note: See TracTickets for help on using tickets.