Opened 7 years ago
Closed 7 years ago
#19357 closed defect (fixed)
Bug in Multivariate Laurent Polynomial Ring
Reported by:  egunawan  Owned by:  

Priority:  critical  Milestone:  sage6.9 
Component:  commutative algebra  Keywords:  Laurent Polynomial Ring, exact division 
Cc:  tscrim  Merged in:  
Authors:  Frédéric Chapoton  Reviewers:  Travis Scrimshaw 
Report Upstream:  N/A  Work issues:  
Branch:  765e300 (Commits, GitHub, GitLab)  Commit:  765e300aeaf9e58c34db97836bcc22bcbb40521f 
Dependencies:  Stopgaps: 
Description
sage: A.<x,y> = LaurentPolynomialRing(QQ) sage: x//y 0 sage: 1//x 0
Change History (7)
comment:1 Changed 7 years ago by
 Keywords Laurent Polynomial Ring exact division added
comment:2 Changed 7 years ago by
 Branch set to u/chapoton/19357
 Commit set to 5dfc679f85677227c372562cf29fdb77fa2b16d6
 Status changed from new to needs_review
comment:3 Changed 7 years ago by
I get at least these failures:
 sage t ../../rings/polynomial/laurent_polynomial_ring.py # 1 doctest failed sage t ../../rings/polynomial/laurent_polynomial.pyx # 2 doctests failed 
However it does fix the problem at hand.
comment:4 Changed 7 years ago by
 Commit changed from 5dfc679f85677227c372562cf29fdb77fa2b16d6 to 765e300aeaf9e58c34db97836bcc22bcbb40521f
Branch pushed to git repo; I updated commit sha1. New commits:
765e300  trac #19357 undo the change to pickle (__reduce__)

comment:5 Changed 7 years ago by
pickling is also broken, but let us keep that for another ticket
comment:6 Changed 7 years ago by
 Priority changed from major to critical
 Reviewers set to Travis Scrimshaw
 Status changed from needs_review to positive_review
It's been broken for a while now I think...Anyways, thanks for figuring out such a fix so quickly.
comment:7 Changed 7 years ago by
 Branch changed from u/chapoton/19357 to 765e300aeaf9e58c34db97836bcc22bcbb40521f
 Resolution set to fixed
 Status changed from positive_review to closed
Note: See
TracTickets for help on using
tickets.
Here is a proposal. Let us see if it passes all tests.
New commits:
trac #19357 fixing floordiv and dump in Laurent polynomials in several var