Opened 4 years ago

Last modified 7 months ago

#19356 needs_work enhancement

QQbar.polynomial_root(): allow approximate root

Reported by: jdemeyer Owned by:
Priority: major Milestone: sage-6.9
Component: algebra Keywords: qqbar
Cc: Merged in:
Authors: Jeroen Demeyer Reviewers:
Report Upstream: N/A Work issues:
Branch: u/cremona/19356 (Commits) Commit: afa179869d23b9aa4c3c42b807858d766030c997
Dependencies: #19362 Stopgaps:

Description

Instead of only allowing an interval containing a root, an approximate root should also be accepted.

Change History (8)

comment:1 Changed 4 years ago by jdemeyer

  • Component changed from basic arithmetic to algebra
  • Dependencies changed from #19330 to #19362

comment:2 Changed 4 years ago by jdemeyer

  • Branch set to u/jdemeyer/qqbar_polynomial_root____allow_approximate_root

comment:3 Changed 4 years ago by jdemeyer

  • Commit set to 41aaf04d4d6dd021a53038c9410f568cc8977958
  • Status changed from new to needs_review

New commits:

2049f5aMove refine_root() to refine_root.pyx
3b34e49Improve refine_root()
41aaf04Allow approximate root in polynomial_root()

comment:4 Changed 4 years ago by cremona

I'm not sure why this never got reviewed, so I am reviewing it after rebasing it on 7.1.beta3 (actually merging not rebasing). The code looks good, but I suppose that #19362 needs finishing first. I am not sure what the needs_work issue is with that one?

comment:5 Changed 4 years ago by cremona

  • Branch changed from u/jdemeyer/qqbar_polynomial_root____allow_approximate_root to u/cremona/19356
  • Commit changed from 41aaf04d4d6dd021a53038c9410f568cc8977958 to afa179869d23b9aa4c3c42b807858d766030c997

New commits:

afa1798Merge branch 'develop (7.1.beta3)' into 19356

comment:6 Changed 4 years ago by cremona

I merged with current develop (7.1.beta3). One minor doctest change was needed in QQbar. I hope I did not break etiquette ('ticket-etiquette'!) by doing so and pushing the branch with my name on...

comment:7 Changed 3 years ago by cheuberg

  • Status changed from needs_review to needs_work

merge conflict

comment:8 Changed 7 months ago by jipilab

  • Keywords qqbar added
Note: See TracTickets for help on using tickets.