Opened 3 years ago

Closed 3 years ago

#19350 closed enhancement (fixed)

A (280, 117, 44, 52)-strongly regular graph

Reported by: ncohen Owned by:
Priority: major Milestone: sage-6.9
Component: graph theory Keywords:
Cc: dimpase Merged in:
Authors: Nathann Cohen Reviewers: Dima Pasechnik
Report Upstream: N/A Work issues:
Branch: d3aad85 (Commits) Commit: d3aad85381e6c2ddde1aa353aa081e2d7a26885e
Dependencies: #19279 Stopgaps:

Description

As the title says. Pretty construction by the way.

Change History (14)

comment:1 Changed 3 years ago by ncohen

  • Branch set to u/ncohen/19350
  • Commit set to 25d946b41075791aac1a8cfb417f791ec6978663
  • Status changed from new to needs_review

New commits:

4f8a84btrac #19279: IncidenceStructure.is_generalized_quadrangle
c26038etrac #19279: Different definition
415fffctrac #19279: Merged with 6.9.rc0
2a56094trac #19279: Settling the definition issue
c590ad1trac #19279: Remove duplicate references
04e92fatrac #19279: Merged with 6.9.rc2
25d946btrac #19350: A (280, 117, 44, 52)-strongly regular graph

comment:2 Changed 3 years ago by dimpase

The cross-intersection of two such partitions P=\{P_1,P_2,P_3\} and P'=\{P'_1,P'_2,P'_3\} being defined as \{P_i\cap P_j: 1\leq i,j\leq 3\},

there is something strange in this definition: the 2nd part does not use P' at all. Also, a space before \cap will make it more readable online.

comment:3 follow-up: Changed 3 years ago by git

  • Commit changed from 25d946b41075791aac1a8cfb417f791ec6978663 to 50c696612c689a1bb2bfbffaf00f2ca211b1f35b

Branch pushed to git repo; I updated commit sha1. New commits:

50c6966trac #19350: Typo

comment:4 in reply to: ↑ 3 Changed 3 years ago by dimpase

Replying to git:

Branch pushed to git repo; I updated commit sha1. New commits:

50c6966trac #19350: Typo

right, but how about the space in front of \cap ? It really does make a difference for online docs (ones you get from sage: blah?)

comment:5 follow-up: Changed 3 years ago by git

  • Commit changed from 50c696612c689a1bb2bfbffaf00f2ca211b1f35b to cdd0b8fd407431f524534cb9c0beb9942ba4bef5

Branch pushed to git repo; I updated commit sha1. New commits:

cdd0b8ftrac #19350: Dima cannot add a space in a docstring without me.

comment:6 in reply to: ↑ 5 Changed 3 years ago by dimpase

  • Status changed from needs_review to positive_review

Replying to git:

Branch pushed to git repo; I updated commit sha1. New commits:

cdd0b8ftrac #19350: Dima cannot add a space in a docstring without me.

well, the branch is not public, and you complain bitterly when I start changing the branch on your ticket to something else, so it seems to be quicker to let you fix it :-)

IMHO, these cap and cup ought to be replaced by unicode symbols. I wonder if this would break html or pdf docs...

comment:7 Changed 3 years ago by ncohen

Hmmmmmm... That makes sense. You should ask that on sage-devel.

Nathann

comment:8 Changed 3 years ago by dimpase

  • Reviewers set to Dima Pasechnik

comment:9 Changed 3 years ago by vbraun

  • Status changed from positive_review to needs_work

PDF docs don't build

comment:10 Changed 3 years ago by dimpase

there is a missing \ after i in

 into `\{\{a,b,c\},\{d,e,f\},\{g,h,i}\}`. The cross-intersection of two

comment:11 Changed 3 years ago by dimpase

  • Status changed from needs_work to needs_review

fixed in the last commit of public/19350

I checked that pdf docs build with this fix.

comment:12 Changed 3 years ago by dimpase

  • Branch changed from u/ncohen/19350 to public/19350
  • Commit changed from cdd0b8fd407431f524534cb9c0beb9942ba4bef5 to d3aad85381e6c2ddde1aa353aa081e2d7a26885e
  • Status changed from needs_review to positive_review

comment:13 Changed 3 years ago by ncohen

Thaaaaaaaanks !

comment:14 Changed 3 years ago by vbraun

  • Branch changed from public/19350 to d3aad85381e6c2ddde1aa353aa081e2d7a26885e
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.