Opened 5 years ago
Closed 5 years ago
#19342 closed enhancement (fixed)
Goethals-Seidel constructions of strongly regular graphs
Reported by: | ncohen | Owned by: | |
---|---|---|---|
Priority: | major | Milestone: | sage-6.10 |
Component: | graph theory | Keywords: | |
Cc: | dimpase | Merged in: | |
Authors: | Nathann Cohen | Reviewers: | Dima Pasechnik |
Report Upstream: | N/A | Work issues: | |
Branch: | 0106ab2 (Commits) | Commit: | 0106ab21b4396709346515564b3609ba1c9cee40 |
Dependencies: | #19341 | Stopgaps: |
Description
As the title says ! Removes yet other graphs from our todo list ;-)
Nathann
Change History (11)
comment:1 Changed 5 years ago by
- Branch set to u/ncohen/19342
- Dependencies set to #19341
- Status changed from new to needs_review
comment:2 Changed 5 years ago by
- Commit set to 78baa464369a7b1bf9c7d29a8b42ced79973fd94
comment:3 Changed 5 years ago by
- Commit changed from 78baa464369a7b1bf9c7d29a8b42ced79973fd94 to 7146ae68993635d63ed7ecf222af880ec8aec5c8
Branch pushed to git repo; I updated commit sha1. New commits:
7146ae6 | trac #19342: The Goethals-Seidel graph, not its complement
|
comment:4 Changed 5 years ago by
- Status changed from needs_review to needs_work
From the patchbot
sage -t --long src/sage/graphs/strongly_regular_db.pyx ********************************************************************** File "src/sage/graphs/strongly_regular_db.pyx", line 362, in sage.graphs.strongly_regular_db.is_goethals_seidel Failed example: t = is_goethals_seidel(28, 15, 6, 10); t Expected: [<function GoethalsSeidelGraph at 0x7feac4de47d0>, 3, 3] Got: [<function GoethalsSeidelGraph at 0x7fdf081e0aa0>, 3, 3] ********************************************************************** File "src/sage/graphs/strongly_regular_db.pyx", line 369, in sage.graphs.strongly_regular_db.is_goethals_seidel Failed example: t = is_goethals_seidel(256, 135, 70, 72); t Expected: [<function GoethalsSeidelGraph at 0x7feac4de47d0>, 2, 15] Got: [<function GoethalsSeidelGraph at 0x7fdf081e0aa0>, 2, 15] ********************************************************************** 1 item had failures: 2 of 10 in sage.graphs.strongly_regular_db.is_goethals_seidel [223 tests, 2 failures, 38.95 s] sage -t --long src/sage/graphs/generators/families.py ********************************************************************** File "src/sage/graphs/generators/families.py", line 716, in sage.graphs.generators.families.GoethalsSeidelGraph Failed example: graphs.GoethalsSeidelGraph(3,3).is_strongly_regular(parameters=True) Expected: (28, 12, 6, 4) Got: (28, 15, 6, 10) ********************************************************************** 1 item had failures: 1 of 3 in sage.graphs.generators.families.GoethalsSeidelGraph [237 tests, 1 failure, 26.84 s] ---------------------------------------------------------------------- sage -t --long src/sage/graphs/strongly_regular_db.pyx # 2 doctests failed sage -t --long src/sage/graphs/generators/families.py # 1 doctest failed ----------------------------------------------------------------------
comment:5 Changed 5 years ago by
- Milestone changed from sage-6.9 to sage-6.10
comment:6 Changed 5 years ago by
- Status changed from needs_work to needs_review
comment:7 Changed 5 years ago by
- Commit changed from 7146ae68993635d63ed7ecf222af880ec8aec5c8 to 0106ab21b4396709346515564b3609ba1c9cee40
Branch pushed to git repo; I updated commit sha1. New commits:
0106ab2 | trac #19342: Doctest
|
comment:9 Changed 5 years ago by
You name. Dima it's getting really boring.
Thanks for the review.
comment:10 Changed 5 years ago by
- Reviewers set to Dima Pasechnik
comment:11 Changed 5 years ago by
- Branch changed from u/ncohen/19342 to 0106ab21b4396709346515564b3609ba1c9cee40
- Resolution set to fixed
- Status changed from positive_review to closed
Note: See
TracTickets for help on using
tickets.
Branch pushed to git repo; I updated commit sha1. New commits:
trac #19340: Better interface for hadamard_matrix
trac #19340: Pre-existing bug that hid several paley constructions
trac #19341: Cleaning/Fix in combinat/matrices/hadamard_matrix
trac #19342: Goethals-Seidel constructions of strongly regular graphs