Opened 4 years ago
Closed 4 years ago
#19325 closed defect (fixed)
cython() does not know how to compile c++
Reported by:  ncohen  Owned by:  

Priority:  major  Milestone:  sage6.9 
Component:  interfaces  Keywords:  
Cc:  jdemeyer  Merged in:  
Authors:  Nathann Cohen  Reviewers:  Jeroen Demeyer, Volker Braun 
Report Upstream:  N/A  Work issues:  
Branch:  d2a8cf6 (Commits)  Commit:  d2a8cf6349e188f75891ceb9c5d4abc9f4f0aed6 
Dependencies:  Stopgaps: 
Description
As reported on sagedevel [1], some .pyx files using c++ that are accepted in Sage's own source code cannot be compiled with '%runfile'. This branch fixes it.
[1] https://groups.google.com/d/topic/sagedevel/AqGEZtl9wVQ/discussion
Change History (15)
comment:1 Changed 4 years ago by
 Branch set to public/19325
 Commit set to e46692cfb367634203dbabaae1c63d90821ad1f8
 Status changed from new to needs_review
comment:2 Changed 4 years ago by
 Commit changed from e46692cfb367634203dbabaae1c63d90821ad1f8 to bb2adb71e3a1459d1ced0438406bb954f0fbc00f
Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:
bb2adb7  trac #19325: cython() does not know how to compile c++

comment:3 Changed 4 years ago by
If you add a doctest, this is good for me.
comment:4 Changed 4 years ago by
 Component changed from build to interfaces
 Reviewers set to Jeroen Demeyer
 Status changed from needs_review to needs_work
comment:5 Changed 4 years ago by
 Commit changed from bb2adb71e3a1459d1ced0438406bb954f0fbc00f to 17a4b54f1a09f70561ef45bbb2db95efd9a26371
Branch pushed to git repo; I updated commit sha1. New commits:
17a4b54  trac #19325: Doctest

comment:6 Changed 4 years ago by
 Status changed from needs_work to needs_review
Here it is !
Nathann
comment:7 Changed 4 years ago by
According to the patchbot, the doc doesn't build.
comment:8 Changed 4 years ago by
I see that, but I don't see how it could be related.
comment:9 Changed 4 years ago by
You have to change the cython()
docstring to start with r"""
since you are adding backslashes to the docstring.
comment:10 Changed 4 years ago by
Argg ! I was precisely fighting with it. Thanks.
comment:11 Changed 4 years ago by
 Commit changed from 17a4b54f1a09f70561ef45bbb2db95efd9a26371 to cf795b38e63ed98446f249c0720d06ce2ed9762f
Branch pushed to git repo; I updated commit sha1. New commits:
cf795b3  trac #19325: Merged with 6.9.rc1

comment:12 Changed 4 years ago by
 Commit changed from cf795b38e63ed98446f249c0720d06ce2ed9762f to d2a8cf6349e188f75891ceb9c5d4abc9f4f0aed6
comment:13 Changed 4 years ago by
 Reviewers changed from Jeroen Demeyer to Jeroen Demeyer, Volker Braun
 Status changed from needs_review to positive_review
comment:14 Changed 4 years ago by
Great thanks!
comment:15 Changed 4 years ago by
 Branch changed from public/19325 to d2a8cf6349e188f75891ceb9c5d4abc9f4f0aed6
 Resolution set to fixed
 Status changed from positive_review to closed
New commits:
trac #19042: Default SAT solver in Sage
trac #19042: Merged with 6.9.rc0
trac #19042: Faster package check
trac #19042: Remove KeyboardInterrupt check
trac #19042: pyx>py
trac #19042: Wrong text
trac #19042: Review
trac #19325: cython() does not know how to compile c++